Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(styles): make width auto on Tabs #11765

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

abbeyhrt
Copy link
Contributor

@abbeyhrt abbeyhrt commented Jul 7, 2022

Closes #

Updates Tabs to be auto-width instead of fixed.

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

Go to Tabs story and verify that the Tabs aren't a fixed width.

@abbeyhrt abbeyhrt requested a review from a team as a code owner July 7, 2022 18:11
@netlify
Copy link

netlify bot commented Jul 7, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit d39b2ca
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62c721ee820151000933480c
😎 Deploy Preview https://deploy-preview-11765--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 7, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d39b2ca
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62c721ee2c3fd70008424513
😎 Deploy Preview https://deploy-preview-11765--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-width looks good!

This is unrelated but can we remove the max-width on the tab items? Or make it bigger? I think it's ellipsing too soon for the auto-width.

@kodiakhq kodiakhq bot merged commit 39f7d1e into carbon-design-system:main Jul 7, 2022
@abbeyhrt
Copy link
Contributor Author

abbeyhrt commented Jul 7, 2022

@aagonzales Yeah for sure! I'll add that to the umbrella issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants