Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: Explore supporting placement of contained tabs on the css grid #12848

Closed
3 tasks done
Tracked by #8487
tay1orjones opened this issue Dec 13, 2022 · 3 comments
Closed
3 tasks done
Tracked by #8487
Assignees
Labels
component: tabs package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 status: blocked 🙅‍♀️ type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Milestone

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Dec 13, 2022

ContainedTabs are intended to sit on the narrow grid so the type is aligned. There's a lot of complexity and open questions here - so we need to explore what's possible and determine the best path forward.

Open questions:

  • Could they sit on the CSS Grid by the existing components being wrapped by Grid/Column?
  • As long as things visually align with a grid, it may not need to technically be in/wrapped by a grid.
    • Is there another way to get consistent type alignment without having the tabs sit on the grid?
  • This would primarily apply to non-automatic tabs. Tabs with automatic (content dictates tab width) would not be able to be placed on the grid.
  • If placed on the grid, are they allowed to wrap?
    • If not, how will the scrollable functionality impact the placement of tabs on the grid?
    • If yes, are there a11y or usability implications with having tabs wrap to a new line?

#12848 (comment)

@tay1orjones tay1orjones changed the title Tabs: Support placement of contained tabs on the css grid Tabs: Explore support placement of contained tabs on the css grid Dec 13, 2022
@tay1orjones tay1orjones changed the title Tabs: Explore support placement of contained tabs on the css grid Tabs: Explore supporting placement of contained tabs on the css grid Dec 13, 2022
@sstrubberg sstrubberg added type: enhancement 💡 version: 11 Issues pertaining to Carbon v11 component: tabs proposal: accepted This request has gone through triaging and we are accepting PR's against it. package: @carbon/react @carbon/react labels Dec 13, 2022
@sstrubberg sstrubberg added this to the 2023 Q1 milestone Dec 13, 2022
@sstrubberg
Copy link
Member

sstrubberg commented Mar 15, 2023

Design issue #13351

@alisonjoseph
Copy link
Member

Dev implementation issue #13353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 status: blocked 🙅‍♀️ type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants