Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainedTabs Secondary Label: Update website docs #13389

Closed
Tracked by #8487
tay1orjones opened this issue Mar 21, 2023 · 2 comments · Fixed by carbon-design-system/carbon-website#3539
Closed
Tracked by #8487

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Mar 21, 2023

With the secondary label now available via a prop #13366, the docs page on the website needs updated

image

There may be other content that needs updated as well.

@kingtraceyj
Copy link
Member

@tay1orjones working on the content currently for this and i noticed that our notification as well as the docs content use the term line tabs but the storybook is using the term default for line tabs. is there a discrepancy there?

image

@tay1orjones
Copy link
Member Author

Hey sorry for the delay - I'll put my half of our slack conversation in here for posterity!

Yeah secondary labels and icons are available as props and no longer require manually composing components together. We can remove that language from the website.

For the line tabs question - there’s no explicit “line tabs” mode in the code. It’s just the default state of TabList. Contained tabs are configured via the contained prop, that can be true or false/omitted

We’re also going to revisit the concept of “default” stories in the storybook once we’ve updated to storybook v7. #13225

It’s similar to the situation with ProgressBar, it’s “indeterminate” by default and then becomes “determinate” when you provide it a value prop.

<ProgressBar label="Progress bar label" /> // indeterminate
<ProgressBar label="Progress bar label" value={75} /> // determinate at 75%

Here’s how that looks in the storybook right now with “default” - link

After working with @aubrey-oneal on the variant exploration stuff, here’s how we’d like it to look (this was from a WIP PR we had to close without merging due to the storybook v7 upgrade) - link

kingtraceyj added a commit to carbon-design-system/carbon-website that referenced this issue May 9, 2023
Updating docs to reflect the new additions to the tab component.
• Updated v11 notification—took out part about composable component API now that we have props available
• Removed caption under Anatomy of line tabs image
• Removed cation under Anatomy of contained tabs image
• Removed caption under Tabs with icon image
• Removed cation under Secondary labels image

Closes carbon-design-system/carbon#13389
kingtraceyj added a commit to carbon-design-system/carbon-website that referenced this issue May 15, 2023
* Update usage.mdx

Updating docs to reflect the new additions to the tab component.
• Updated v11 notification—took out part about composable component API now that we have props available
• Removed caption under Anatomy of line tabs image
• Removed cation under Anatomy of contained tabs image
• Removed caption under Tabs with icon image
• Removed cation under Secondary labels image

Closes carbon-design-system/carbon#13389

* Update src/pages/components/tabs/usage.mdx

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>

* Update usage.mdx

updated grid alignment notification
• took out underscores
• rewrote copy

* Update usage.mdx

Updated styling for grid alignment notification

---------

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants