Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support left/right tooltip positioning #2678

Closed
emyarod opened this issue May 10, 2019 · 5 comments
Closed

Support left/right tooltip positioning #2678

emyarod opened this issue May 10, 2019 · 5 comments
Assignees
@asudoh
Labels
role: dev 🤖 type: enhancement 💡

Comments

@emyarod
Copy link
Member

emyarod commented May 10, 2019

image

image from this comment

Related: #2460 #2604
@emyarod emyarod mentioned this issue May 10, 2019
Closed
@asudoh
Copy link
Contributor

asudoh commented May 10, 2019

@shixiedesign Do you this the left/right "sides" apply to definition tooltip, too? (Or is it only for icon tooltip?) Thanks!

@shixiedesign
Copy link
Contributor

Hi @asudoh @emyarod, I just confirmed: side tooltips are only for icon tooltip on hover, so not definition tooltip.

Expected usage of side tooltip is on side rails & vertical toolbars:

image

@lovemecomputer lovemecomputer mentioned this issue May 13, 2019
Closed
52 tasks
asudoh added a commit to asudoh/carbon-components that referenced this issue May 15, 2019
@asudoh
feat(tooltip): introduce alignment
a8f7437 
This change introduces left/right alignments to icon tooltip.

Refs carbon-design-system#2678.
@asudoh asudoh mentioned this issue May 15, 2019
Merged
shixiedesign pushed a commit that referenced this issue May 16, 2019
@asudoh @shixiedesign
feat(tooltip): introduce alignment (#2732)
6f7183e 
* feat(tooltip): introduce alignment

This change introduces left/right alignments to icon tooltip.

Refs #2678.

* chore(tooltip): format fix

* chore(TooltipIcon): replace alignment with align
This was referenced May 16, 2019
Closed
Closed
@shixiedesign shixiedesign reopened this May 16, 2019
@shixiedesign
Copy link
Contributor

shixiedesign commented May 16, 2019 •
edited
Loading

To summarize our tooltip's functionalities:

Interactive tooltip:

  • Position: top, bottom, left right. Done!
  • Alignment: only center. Done!

Definition tooltip:

  • Position: only top & bottom. Done!
  • Alignment: start, center, end. Done!

Icon tooltip:

  • Position: top&button, still need left, right
  • Alignment: center, still need start, end

So we still need a PR for the bolded items on Icon tooltip then we can close this item. Does that seem right to you guys? @asudoh @emyarod

📖 Guidelines to add

@connor-leech I think ☝️ above looks like good info to include in our Tooltip usage section.

@emyarod
Copy link
Member Author

emyarod commented May 16, 2019

all of the icon tooltip requirements are fulfilled

position: top and bottom #2749

position: left, right #2732

alignment: start, end #2732

@shixiedesign
Copy link
Contributor

Perfect! Thanks @emyarod Closing issue then.

@emyarod emyarod mentioned this issue Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asudoh asudoh

Labels
role: dev 🤖 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asudoh @emyarod @shixiedesign