refactor(tooltip): avoid magic number positioning #2749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
force-pushed
the
2748-universal-tooltip-positioning
branch
from
66e9bb8
to
9ac2e89
Compare
|
Deploy preview for the-carbon-components ready! Built with commit 66e9bb8 https://deploy-preview-2749--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 66e9bb8 https://deploy-preview-2749--carbon-components-react.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit 9ac2e89 https://deploy-preview-2749--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 9ac2e89 https://deploy-preview-2749--carbon-components-react.netlify.com |
This was referenced May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2748
This PR avoids relying on magic numbers to position icon tooltips. Similar logic can be applied for left/right positioning tooltips in #2731
Changelog
New
Changed
Removed
button.scssTesting / Reviewing
Ensure that tooltips render as expected