-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVT 1 &AVT 2 - Default Tooltip has keyboard issue and TooltipDefinition and Icon have DAP violations #2736
Comments
hi @snidersd! #2656 only removes the if I understand correctly, we are getting conflicting information (or have misinterpreted the feedback) about the necessity of |
@emyarod It looks like the mix up is in the use of aria-label vs aria-labelledby. In the original issue #2458 both the aria-labelledby and an aria-label were on the svg which effectively meant there were 2 different labels on the same element. As mentioned in #2193 an aria-label is typically used if there is no visible label to reference or aria-labelledby is used to reference a visible label. The DAP error is because neither one exist in the updated React Tooltip. If you add aria-labelledby to the and reference the tooltip label that will also fix the issue. Note: The Vanilla Tooltip Component has no Violations using aria-labelledby in the
. |
@dakahn Please add the react label to this issue. Thx! |
@dakahn Please add this issue to the IBM Carbon Copy Milestone. Thx! |
I'm only seeing the DAP issue with the TooltipDefintion and the TooltipIcon. However, the Tooltip, which is actually a Modal does not restrict tab focus to the modal. |
@snidersd Circling back on this. Looks like the DAP errors are cleared 🥂. As for the AVT2 (keyboard a11y) violation what we're talking about is making our tooltip if it's open? Or only tooltips that have links/buttons in them? I'm not a huge fan of using tooltips in that way anyway (hiding options etc) -- my assumption is that this isn't suggested use, but we're just showing off what you could do. If we changed our example would a focus trap still be necessary? |
Cool! I'll wait for @elizabethsjudd's PR to drop and then port changes over 👍 |
We should open a separate ticket for the inaccessible tooltip elements. My hunch is that we actually don't intend our tooltips to have confirmation buttons etc... |
@snidersd Couldn't we classify this DAP error as a React app false positive? If the tooltip has focus -- it's open. And if it's open, that aria-describedby id is valid. It's only in the situation where we're scanning the DOM using AAT that this is a problem unless there's something I'm missing. |
This issue is related to #2458
Retested after the latest fix #2656 and there is still a DAP failure.
The original fix for #2458 was to remove aria-labelledby="_carbon-tooltip-trigger_qonq7h6yqf", but the aria-label="tooltip" was also removed which is causing the new violation. (see screenshot):
Please add aria-label="tooltip" back in to fix.
The text was updated successfully, but these errors were encountered: