fix(tooltip): add aria-labelledby and adjust aria-describedby attributes #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 7274a0a https://deploy-preview-4073--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 7274a0a https://deploy-preview-4073--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 7274a0a |
dakahn
changed the title
joshblack
approved these changes
Sep 24, 2019
jnm2377
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2736
Some aria fixes improving screen reader support for the component.
Changelog
aria-describedby(so the tooltip's content will be read)aria-describedbytoaria-labelledby(so it will be announced)Testing / Reviewing
cmd-F5to enable VoiceOvertabto move focus to the default tooltip iconWhat you should hear
The tooltip should expand, the element should be announced, and the content should be read.