fix(Tooltip): remove ARIA attribute #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2019
emyarod
force-pushed
the
2458-avt1-tooltip-dap-violation
branch
from
d295a07
to
b0078ad
Compare
emyarod
force-pushed
the
2458-avt1-tooltip-dap-violation
branch
from
b0078ad
to
1dab64c
Compare
|
Deploy preview for the-carbon-components ready! Built with commit b0078ad https://deploy-preview-2656--the-carbon-components.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit 81088a3 https://deploy-preview-2656--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit b0078ad https://deploy-preview-2656--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 81088a3 https://deploy-preview-2656--carbon-components-react.netlify.com |
joshblack
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2458
This PR removes the
aria-labelledbyattribute on the tooltip to avoid a DAP violation