Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab component throws warning about Href and tabIndex #7237

Closed
amortiz opened this issue Nov 6, 2020 · 2 comments
Closed

Tab component throws warning about Href and tabIndex #7237

amortiz opened this issue Nov 6, 2020 · 2 comments

Comments

@amortiz
Copy link

amortiz commented Nov 6, 2020

Having this code:
<Tabs> <Tab> hello </Tab> </Tabs> throws console warnings, which break our unit tests:

index.js:27 Warning: The prop `href` has been deprecated for the Tab component. It will be removed in the next major release 
    in App (at src/​index.js:13)
index.js:27 Warning: The prop `tabIndex` has been deprecated for the Tab component. It will be removed in the next major release 

I'm not passing those in, probably the default props inside Tab is doing this?

You can see here
https://codesandbox.io/s/sleepy-sid-h56nf

@tw15egan
Copy link
Collaborator

tw15egan commented Nov 6, 2020

Fixed in #7221 and #7231 and will be included in the next release 👍

@starpit
Copy link

starpit commented Nov 7, 2020

Will this fix be included in a 7.23.x? (we can't afford to ride your wave of minor releases, as they consistently introduce breaking changes and regressions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants