Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switching Carbon tabs can cause content to scroll off-viewport #6126

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Nov 6, 2020

carbon-components-react 7.23.0 (versus 7.22.0) had a few DOM-altering changes:

  1. a -> button for Tab child
  2. [aria-hidden=true] => [hidden]

This required a few changes to CSS rules and test selectors.

Fixes #6014

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #6126 (9dfcb4b) into master (1ad0af8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6126   +/-   ##
=======================================
  Coverage   61.98%   61.98%           
=======================================
  Files          84       84           
  Lines        2662     2662           
  Branches      656      656           
=======================================
  Hits         1650     1650           
  Misses        769      769           
  Partials      243      243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad0af8...8aac990. Read the comment docs.

@starpit starpit force-pushed the fix-6014b branch 4 times, most recently from 3fdccab to 9f803a4 Compare November 7, 2020 18:29
@starpit
Copy link
Contributor Author

starpit commented Nov 7, 2020

sigh, carbon 7.23 deprecated Tab props, but itself persisted in using those props.

carbon-design-system/carbon#7237

who knows when that fix will be released...

@starpit starpit merged commit 51a2aad into kubernetes-sigs:master Nov 7, 2020
@starpit starpit deleted the fix-6014b branch November 7, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching Carbon tabs can cause content to scroll off-viewport.
1 participant