Fix issue in Jest setup, fix failing tests #7221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 938217f |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 938217f https://deploy-preview-7221--carbon-components-react.netlify.app |
|
bump @aledavila @andreancardona if you all have a sec today 👀 Also free to go over anything if there are any questions! |
andreancardona
approved these changes
Nov 5, 2020
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7186
While working through #7186 I noticed that our test suite should have been failing for the deprecation notice, but then it wasn't. When digging in I noticed a bug with how we error out on console statements that were swallowing errors. This PR fixes that issue and any corresponding tests that failed as a result.
Changelog
New
Changed
beforeEach