Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): replace cds--tab--scrollable class with cds--tabs #10194

Merged
merged 8 commits into from
Dec 1, 2021
Merged

fix(styles): replace cds--tab--scrollable class with cds--tabs #10194

merged 8 commits into from
Dec 1, 2021

Conversation

abbeyhrt
Copy link
Contributor

@abbeyhrt abbeyhrt commented Nov 30, 2021 •
edited
Loading

Ref: #10086, #8487

Switches cds-tabs--scrollable--** to cds-tabs--** and creates a next version of TabsSkeleton. I know that class names aren't technically a breaking change but i went ahead and separated it since we are already exporting /next versions of tabs.

Changelog

New

  • TabsSkeleton in /next

Changed

  • Minor story changes to import to ensure that the right component was being used.
  • reordered Tabs styles
  • replaced cds--tabs--scrollable with cds--tabs

Removed

  • outdated comments

Testing / Reviewing

Check to make sure that Tabs looks the same as before and that cds--tabs--scrollable is replaced everywhere but only for @carbon/react

@abbeyhrt abbeyhrt requested a review from a team as a code owner November 30, 2021 16:47
@netlify
Copy link

netlify bot commented Nov 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 923f71e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61a7a5ccdf3e89000702536a

😎 Browse the preview: https://deploy-preview-10194--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Nov 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 923f71e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61a7a5ccd08aa300073758c6

😎 Browse the preview: https://deploy-preview-10194--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 30, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: e52b58a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61a655a395e4c00007fba787

😎 Browse the preview: https://deploy-preview-10194--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Nov 30, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 923f71e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61a7a5ccb20b8d00076128b1

😎 Browse the preview: https://deploy-preview-10194--carbon-components-react.netlify.app

aledavila
aledavila approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tabs look the same

@abbeyhrt abbeyhrt enabled auto-merge (squash) December 1, 2021 16:42
@abbeyhrt abbeyhrt merged commit 4b416b9 into carbon-design-system:main Dec 1, 2021
@abbeyhrt abbeyhrt mentioned this pull request Dec 14, 2021
Closed
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@ariellalgilmore
fix(cwc): storybook link (carbon-design-system#10194)
187a180 
### Related Ticket(s)

N/A
### Description

Clicking on the storybook title for cwc was linking us back to the old repo

### Changelog


**Changed**

-updated link to the current repo


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abbeyhrt @tay1orjones @aledavila