-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tabs): Dismissable tabs #13529
feat(Tabs): Dismissable tabs #13529
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…813-tabs-add-dismissable-functionality-to-tab
- dismissable functionality refactor - behavioral bug fixes
…813-tabs-add-dismissable-functionality-to-tab
Not sure why |
…813-tabs-add-dismissable-functionality-to-tab
…hub.com:francinelucca/carbon into 12813-tabs-add-dismissable-functionality-to-tab
…813-tabs-add-dismissable-functionality-to-tab
This should be ready for another visual review @kingtraceyj @laurenmrice Attaching some videos as well Screen.Recording.2023-05-11.at.7.32.47.PM.movScreen.Recording.2023-05-11.at.7.32.13.PM.movStill wondering if the disabled dismiss button should have an active color or not since disabled tabs are dismissable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…813-tabs-add-dismissable-functionality-to-tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks go to good! 💥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 looks amazing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 looks amazing!
…813-tabs-add-dismissable-functionality-to-tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM!!
Closes #12813
This adds dismissable functionality to tabs
dismissable
&onTabCloseRequest
props toTabs
Dismissable
Tabs storyTODO:
Changelog
New
dismissable
&onTabCloseRequest
props inTabs
, also passed through theTabsContext
Dismissable
control inTabs
Playground storyChanged
Tabs
scroll buttons visibility logic to account for deletable tabs@carbon/react
instead ofcarbon-components-react
)Tab
whenTabsContext
's value hasdismissable
onKeyDown
handle inTab
to callonTabCloseRequest
whendelete
is pressed on dismissable tabTesting / Reviewing