-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs: add dismissable functionality to tab #12813
Comments
@laurenmrice @kingtraceyj What's the expected behavior if this happens? what should be rendered if a user tries to mix dismissable tabs with non-operable tabs? |
is the keyboard close interaction performed through focus > space/enter or just the Escape key? |
@francinelucca The WAI-ARIA Tabs pattern states Delete should be used, not Escape. All children elements of |
I'd vote for dismissable to "win" and the icons on all other tabs are not rendered. With how composable the API is though we won't always be able to restrict this I think. It might be something we could warn about in dev mode though through conditional props or something? |
@francinelucca for clarity though, the spec does allow for tabs to be dismissable and have a descriptive icon #8487 (comment), it's just that all tabs must be dismissable or not I think Adding this functionality is slated for a separate issue #12845 |
This issue is for the implementation of dismissible functionality for tabs.
Open questions:
tab
role spec says children are presentational only#12813 (comment)
The text was updated successfully, but these errors were encountered: