fix: form spacing

[breid1313]

Closes #2343

Changelog

Changed

• added 24px/1.5 rem margin-bottom to form--form-item using the $carbon--spacing-06 following the Form Style Guide
• adjusted the margin-bottom on form--fieldset to $carbon--spacing-06 for consistency

Testing / Reviewing

Storybook before (small snippet):

Storybook after (small snippet):

[netlify]

Deploy preview for the-carbon-components ready!

Built with commit c97cce7

https://deploy-preview-4576--the-carbon-components.netlify.com

[netlify]

Deploy preview for carbon-elements failed.

Built with commit c97cce7

https://app.netlify.com/sites/carbon-elements/deploys/5dc2243359201300083a33bf

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit c97cce7

https://deploy-preview-4576--carbon-components-react.netlify.com

[joshblack]

Would adding this to bx--form-item unexpected add margin for folks using this control? Might be good to offer it by default, but might catch folks off guard if we add this layout potentially

[emyarod]

yeah I think this is part of a discussion that's been on hold since the v10 effort began

[aagonzales]

If dev thinks its ok to update without breaking people then it good to me.

[joshblack]

Coming back to this, looks like we can't update it without causing a breaking change for certain users 😞Went ahead and added a v11 label to the corresponding issue so we make sure to address this in our next update.

Just wanted to say thanks so much for your time and effort here, really appreciate it 🙏 Sorry that things took so long and ended up the way that they did 😞

[breid1313]

@joshblack no need to apologize! Happy to (continue to) help where I can 👍 . Thanks for following up 😄