Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: form spacing #4576

Closed
wants to merge 2 commits into from
Closed

fix: form spacing #4576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
302756a
fix: form spacing
Nov 5, 2019
c97cce7
Merge branch 'master' into form-spacing
joshblack Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/src/components/form/_form.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
@mixin form {
.#{$prefix}--fieldset {
@include reset;
margin-bottom: $carbon--spacing-07;
margin-bottom: $carbon--spacing-06;
}

.#{$prefix}--form-item {
Expand All @@ -29,6 +29,7 @@
// `flex-direction: row`
flex: 1 1 auto;
align-items: flex-start;
margin-bottom: $carbon--spacing-06;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would adding this to bx--form-item unexpected add margin for folks using this control? Might be good to offer it by default, but might catch folks off guard if we add this layout potentially

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think this is part of a discussion that's been on hold since the v10 effort began

}

.#{$prefix}--label {
Expand Down