fix(data-table): remove inline edit short table styles #8212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
requested review from
tw15egan,
andreancardona,
a team and
laurenmrice
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit a520fc8 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit a520fc8 https://deploy-preview-8212--carbon-components-react.netlify.app |
emyarod
force-pushed
the
8206-remove-inline-edit-table-styles
branch
from
9e6b0b6
to
901c0f2
Compare
|
DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request |
emyarod
force-pushed
the
8206-remove-inline-edit-table-styles
branch
from
901c0f2
to
735fa03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8206
This PR removes broken style overrides for form controls within short data tables
Testing / Reviewing
Confirm that inline selects within the short data table have the correct spacing and alignment for the chevron icon. The extra table column should be removed from the examples before merging