fix(data-table): add table scope to form control overrides #8295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
Deploy preview for carbon-elements ready! Built with commit 6debd05 |
|
Deploy preview for carbon-components-react ready! Built with commit 6debd05 https://deploy-preview-8295--carbon-components-react.netlify.app |
tay1orjones
approved these changes
Apr 5, 2021
joshblack
approved these changes
Apr 5, 2021
joshblack
requested review from
a team and
jeanservaas
and removed request for
a team
emyarod
force-pushed
the
8286-light-input-field-background-colors
branch
from
0173018
to
0dbadb5
Compare
emyarod
force-pushed
the
8286-light-input-field-background-colors
branch
from
0dbadb5
to
9d531a0
Compare
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 7, 2021
…sign-system#8295) * fix(data-table): add table scope to form control overrides * docs(DataTable): remove example form inputs
tay1orjones
added a commit
that referenced
this pull request
Apr 7, 2021
* fix(data-table): add table scope to form control overrides (#8295) * fix(data-table): add table scope to form control overrides * docs(DataTable): remove example form inputs * chore(release): v10.32.1 Co-authored-by: emyarod <emyarod@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8286
Related #8212
This PR scopes the table form control styles to the data table component to prevent standalone form controls from inheriting the styles
Testing / Reviewing
Confirm that inline table form controls receive the correct color token while standalone form controls are unaffected