feat(Components): update color tokens (1/2) #8425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit e9d9182 |
tw15egan
reviewed
Apr 15, 2021
packages/components/src/components/code-snippet/_code-snippet.scss
Outdated
Show resolved
Hide resolved
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit e9d9182 https://deploy-preview-8425--carbon-components-react.netlify.app |
aagonzales
reviewed
Apr 16, 2021
packages/components/src/components/code-snippet/_code-snippet.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/code-snippet/_code-snippet.scss
Outdated
Show resolved
Hide resolved
andreancardona
approved these changes
Apr 26, 2021
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Jun 29, 2021
…stem#8425)" This reverts commit 63aae51.
andreancardona
added a commit
that referenced
this pull request
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8149
Changed
Had some questions about some of the tokens (left in comments) - can update once questions are answered.
Testing / Reviewing
Test against visual regression for components.