fix(Modal): content spacing styles #8495
Conversation
|
Deploy preview for carbon-elements ready! Built with commit d8cdf61 |
|
Deploy preview for carbon-components-react ready! Built with commit d8cdf61 https://deploy-preview-8495--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit ae95e90 |
|
Deploy preview for carbon-components-react ready! Built with commit ae95e90 https://deploy-preview-8495--carbon-components-react.netlify.app |
|
Not sure if this is related to this PR or not but the fade at the bottom of the content isn't showing up when there is scrolling content. I'm not seeing it in regular story book so its probably not related, just wanted to check. |
|
@jnm2377 it seems like this update will make the Should we add a deprecate notice to the prop, and leave a coment to remove the Other changes look great! |
There was a problem hiding this comment.
should the xs modal paragraphs have no additional padding or am I misinterpreting this note? #8373 (comment)
|
@tw15egan good call, updated with deprecation warning 👍🏽 |
@emyarod I'll defer to @aagonzales on this. I left the xs padding as is. |
|
Oh good catch. The |
|
It looks like XS still has some padding when the modal is displayed on smaller screens. It looks like the rest of the size variants don't have this padding. XS All other variants |
Closes #8373
xsmodal content always spans full width, even paragraphs/text.