Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): add safari media query for overflow indicator #8510

Merged
merged 2 commits into from
May 4, 2021
Merged

fix(modal): add safari media query for overflow indicator #8510

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd66d8a
fix(modal): add safari media query for overflow indicator
emyarod Apr 27, 2021
6866e28
Merge branch 'main' into modal-overflow-indicator-safari-media-query
kodiakhq[bot] May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/components/src/components/modal/_modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,22 @@
grid-column: 1/-1;
width: 100%;
height: rem(32px);
// Safari interprets `transparent` differently, so make color token value transparent instead:
background-image: linear-gradient(to bottom, rgba($layer, 0), $layer);
background-image: linear-gradient(to bottom, transparent, $layer);
content: '';
pointer-events: none;
}

// Safari-only media query
// won't appear correctly with CSS custom properties
// see: code snippet and tabs overflow indicators
@media not all and (min-resolution: 0.001dpcm) {
@supports (-webkit-appearance: none) and (stroke-color: transparent) {
.#{$prefix}--modal-content--overflow-indicator {
background-image: linear-gradient(to bottom, rgba($layer, 0), $layer);
}
}
}

.#{$prefix}--modal-content:focus
~ .#{$prefix}--modal-content--overflow-indicator {
width: calc(100% - 4px);
Expand Down