refactor(sharedStyles): use param object instead of list of params #8700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
May 17, 2021
|
Deploy Preview for carbon-elements ready! Built with commit a426eec |
|
Deploy Preview for carbon-components-react ready! Built with commit a426eec https://deploy-preview-8700--carbon-components-react.netlify.app |
laurenmrice
approved these changes
May 18, 2021
andreancardona
approved these changes
May 18, 2021
emyarod
force-pushed
the
refactor-synccolorstyle
branch
from
9b70e66
to
a426eec
Compare
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the refactoring from #8188 while it remains blocked. The
syncColorStylefunction now uses a param object instead of a list of params. This helped with linting by triggering warnings with unused params while refactoring. It will also help in case new params need to be added in the future, since the order of the function params will be unimportant within the config object.Testing / Reviewing
Confirm there are no regressions with the current plugin behavior since this change is 100% organizational
carbon-elements.sketchplugin.zip