Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add actionable notification #9494

Merged
merged 15 commits into from
Sep 28, 2021
Merged

feat: add actionable notification #9494

merged 15 commits into from
Sep 28, 2021

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Aug 17, 2021 •
edited
Loading

Closes #8703

Adds ActionableNotification as a new component and modify Inline/Toast notification components to no longer accept actions. The aim here is to promote a more clear onramp for best accessibility practices with notifications.

Changelog

New

  • actionable-notification: add new component, styles, storybook docs

Changed

  • inline-notification: no longer accept actions or interactive children
  • toast-notification: no longer accept actions or interactive children

Testing / Reviewing

  • View the carbon-next storybook, all 3 notification stories
  • Ensure various controls/knobs work and the component renders as expected
  • Particuarly look at the ActionableNotification component and validate all variants render appropriately, across the 4 different themes too
  • View the legacy/normal storybook and make sure the existing Toast/Inline are not impacted with changes from next

@netlify
Copy link

netlify bot commented Aug 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: b105447

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61527322b4678700083082ac

😎 Browse the preview: https://deploy-preview-9494--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b105447

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6152732283279900074191ba

😎 Browse the preview: https://deploy-preview-9494--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 17, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: b105447

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61527322cf3a2900078eed1a

😎 Browse the preview: https://deploy-preview-9494--carbon-components-react.netlify.app

@tay1orjones tay1orjones marked this pull request as ready for review September 13, 2021 19:27
@tay1orjones tay1orjones requested review from a team as code owners September 13, 2021 19:27
@tay1orjones tay1orjones requested review from joshblack and dakahn and removed request for sstrubberg September 13, 2021 19:27
@tay1orjones
Copy link
Member Author

I'm going to take a second look at this - I just realized I need to retool how I'm using the button component tokens now that #9663 has landed

@tay1orjones tay1orjones removed the request for review from tw15egan September 22, 2021 21:41
dakahn
dakahn approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with JAWS 2020 on Windows 10 and read well as far as I can tell 👍🏾 Awesome work 🏄🏾

@kodiakhq kodiakhq bot merged commit 4dfcae7 into carbon-design-system:main Sep 28, 2021
@tay1orjones tay1orjones deleted the 8703-toast-actions branch September 28, 2021 15:46
@joshblack joshblack mentioned this pull request Sep 28, 2021
Merged
@tay1orjones tay1orjones mentioned this pull request Oct 22, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Notification] Actionable/Persistent variant
3 participants
@tay1orjones @joshblack @dakahn