Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(styles): add component tokens to button, tag #9663

Merged
merged 6 commits into from
Sep 15, 2021
Merged

feat(styles): add component tokens to button, tag #9663

merged 6 commits into from
Sep 15, 2021

Conversation

joshblack
Copy link
Contributor

Closes #9358

This implements automatic component tokens for button and tag.

Changelog

New

Changed

  • Update button to use component token format
  • Update tag to use component token format

Removed

Testing / Reviewing

  • Switch themes for button and tag and verify tokens switch as expected based on theme

@joshblack joshblack requested a review from a team as a code owner September 14, 2021 21:53
@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 9358754

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6142313a4409c80008473125

😎 Browse the preview: https://deploy-preview-9663--carbon-react-next.netlify.app

@joshblack joshblack requested review from sstrubberg and jnm2377 and removed request for tw15egan and andreancardona September 14, 2021 21:53
@netlify
Copy link

netlify bot commented Sep 14, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: fd71cc6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614119be1dafec0007fc354b

😎 Browse the preview: https://deploy-preview-9663--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 14, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: fd71cc6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614119be76e8b100077ab7a2

😎 Browse the preview: https://deploy-preview-9663--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9358754

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6142313ad439fe0008efee48

😎 Browse the preview: https://deploy-preview-9663--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9358754

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614231392f8b550007022f27

😎 Browse the preview: https://deploy-preview-9663--carbon-components-react.netlify.app

jnm2377
jnm2377 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sstrubberg sstrubberg enabled auto-merge (squash) September 15, 2021 17:45
@sstrubberg sstrubberg merged commit cbb8fa9 into carbon-design-system:main Sep 15, 2021
@tay1orjones tay1orjones mentioned this pull request Sep 20, 2021
Merged
@joshblack joshblack mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component Token Refactor
3 participants
@joshblack @sstrubberg @jnm2377