Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace ALL straight single quotes with apostrophes in Gatsby them site #600

Closed
mjabbink opened this issue Dec 10, 2019 · 1 comment · Fixed by #610
Closed

replace ALL straight single quotes with apostrophes in Gatsby them site #600

mjabbink opened this issue Dec 10, 2019 · 1 comment · Fixed by #610

Comments

@mjabbink
Copy link
Contributor

On captions page for example there are single straight quotes vs. apostrophe

https://gatsby-theme-carbon.now.sh/components/Caption

Screen Shot 2019-12-10 at 8 50 40 AM

Screen Shot 2019-12-10 at 8 50 43 AM
@mjabbink
Copy link
Contributor Author

Nothing from Carbon or IDL can ever have these buggers! Everyone on team must become proficient in identifying proper use of quotes, apostrophes, en dashes, em dashes.

vpicone added a commit to vpicone/gatsby-theme-carbon that referenced this issue Dec 13, 2019
@vpicone
fix: use whitespace to ensure smart quotes get replaced in text content
8bf0574 
closes carbon-design-system#600
@vpicone vpicone mentioned this issue Dec 13, 2019
Merged
vpicone added a commit that referenced this issue Dec 13, 2019
@vpicone
fix: use whitespace to ensure smart quotes get replaced in text (#610)
8a75d38 
* fix: use whitespace to ensure smart quotes get replaced in text content closes #600

* fix: update all dumb quotes in source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use whitespace to ensure smart quotes get replaced in text vpicone/gatsby-theme-carbon
1 participant
@mjabbink