Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use whitespace to ensure smart quotes get replaced in text #610

Merged
merged 4 commits into from
Dec 13, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Dec 13, 2019

closes #600

Sites using the theme have quotes replaced automatically if they use the components properly. We didn't use the Caption component correctly here so the tool didn't process the text.

@vercel
Copy link

vercel bot commented Dec 13, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/qgc9mdsl9
🌍 Preview: https://gatsby-theme-carbon-git-fork-vpicone-caption-quotes.carbon-design-system.now.sh

@vercel vercel bot temporarily deployed to staging December 13, 2019 17:27 Inactive
@vpicone vpicone merged commit 8a75d38 into carbon-design-system:master Dec 13, 2019
@vpicone vpicone deleted the caption-quotes branch December 13, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace ALL straight single quotes with apostrophes in Gatsby them site
1 participant