fix: inline code font size #753
Conversation
alisonjoseph
requested review from
a team,
vpicone and
sstrubberg
and removed request for
a team
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/f6yafovch |
| td > code { | ||
| font-size: 12px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Without this it was computing to 12.25px instead of 12px. Has something to do with the specificity in the page-table scss file.
There was a problem hiding this comment.
I think It was computing to 12.25 because it was using em. So when the font size goes down to 14, .875*14 = 12.25
| @@ -11,13 +11,17 @@ | |||
| position: relative; | |||
| display: inline; | |||
| padding: 0 0.5em; | |||
| font-size: 0.75em; | |||
| font-size: 0.875em; | |||
There was a problem hiding this comment.
| font-size: 0.875em; | |
| font-size: 0.75rem; |
There was a problem hiding this comment.
looks like it shoulda been rem so it's relative to the root instead of whatever the current font-size is.
There was a problem hiding this comment.
@vpicone changing it to .75rem makes it too small(12). should be 14px for body text.
There was a problem hiding this comment.
Whoops! My bad, I’d just leave the r in there so it’s /16 instead of /whatever the current font size is.
|
@vpicone just updated to |
Closes #459