Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline code font size #753

Merged
merged 7 commits into from
Mar 5, 2020
Merged

fix: inline code font size #753

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d533b17
fix: inline code font size
alisonjoseph Mar 3, 2020
299c6ec
fix: table code size
alisonjoseph Mar 3, 2020
1645b02
Update packages/gatsby-theme-carbon/src/components/Code/Code.module.scss
vpicone Mar 5, 2020
d1deda4
Merge branch 'master' into fix-code-size
vpicone Mar 5, 2020
bcfba00
fix: font size
alisonjoseph Mar 5, 2020
8ed5fde
Merge branch 'master' into fix-code-size
sstrubberg Mar 5, 2020
c72a0ca
Merge branch 'master' into fix-code-size
vpicone Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/gatsby-theme-carbon/src/components/Code/Code.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,17 @@
position: relative;
display: inline;
padding: 0 0.5em;
font-size: 0.75em;
font-size: 0.875rem;
bottom: 0.0625em;
border-radius: 4px;
background-color: $ui-03;
color: $text-01;
}

td > code {
font-size: 0.75rem;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this it was computing to 12.25px instead of 12px. Has something to do with the specificity in the page-table scss file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think It was computing to 12.25 because it was using em. So when the font size goes down to 14, .875*14 = 12.25

// Add's additional length for scrolling under sidebar
.token:last-of-type {
margin-right: 64px;
Expand Down