Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 943-audit-avt1-homepage-content-not-in-landmark #944

Merged
merged 7 commits into from
Jul 27, 2020
Merged

fix: 943-audit-avt1-homepage-content-not-in-landmark #944

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8d797b2
fix: issue 808 - removed button in ImageGallereyImage
Apr 9, 2020
e1e39eb
Revert "fix: issue 808 - removed button in ImageGallereyImage"
Apr 9, 2020
d1b4927
Merge branch 'master' of github.com:carbon-design-system/gatsby-theme…
Jul 8, 2020
48e3ce9
Merge branch 'master' of github.com:carbon-design-system/gatsby-theme…
Jul 26, 2020
80d3fa6
fix: 943-audit-avt1-homepage-banner-role
Jul 26, 2020
de4b999
Merge branch 'main' into 943-audit-avt1-homepage-banner-role
kodiakhq[bot] Jul 26, 2020
8daec93
Merge branch 'main' into 943-audit-avt1-homepage-banner-role
vpicone Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/gatsby-theme-carbon/src/components/Container/Container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,19 @@ const Container = ({ children, homepage, theme }) => {

return (
<>
<span hidden id="overlay-label">
Collapse navigation items
</span>
<div
role="button"
aria-labelledby="overlay-label"
tabIndex="0"
className={cx(overlay, { [visible]: overlayVisible })}
onClick={closeNavs}
onKeyPress={closeNavs}
role="presentation"
tabIndex="-1"
/>
<main
id="main-content"
role="presentation" // needed for jsx-a11y/no-noninteractive-element-interactions
onClick={closeNavs}
onKeyPress={closeNavs}
aria-hidden={overlayVisible}
className={containerClassNames}>
{children}
Expand Down