Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 943-audit-avt1-homepage-content-not-in-landmark #944

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Jul 26, 2020

Closes #943

please note that the branch name does not match the PR / fix - personal mistake

@andreancardona andreancardona requested a review from a team July 26, 2020 13:15
@andreancardona andreancardona self-assigned this Jul 26, 2020
@andreancardona andreancardona requested review from vpicone and jnm2377 and removed request for a team July 26, 2020 13:15
@vercel
Copy link

vercel bot commented Jul 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/2tsbfi1p2
✅ Preview: https://gatsby-theme-ca-git-fork-andreancardona-943-audit-avt1-h-8dcc31.carbon-design-system.vercel.app

@vercel vercel bot temporarily deployed to Preview July 26, 2020 13:15 Inactive
@vpicone
Copy link
Contributor

vpicone commented Jul 27, 2020

@andreancardona did this resolve DAP issue? Hopefully without out creating new ones haha.

@andreancardona
Copy link
Contributor Author

@andreancardona did this resolve DAP issue? Hopefully without out creating new ones haha.

@vpicone @jnm2377 Looks like it did! :)

Screen Shot 2020-07-27 at 11 08 20 AM

@jnm2377
Copy link
Contributor

jnm2377 commented Jul 27, 2020

If you click on the main section when the sidenav is open, there's like a focus outline on part of it. Is it meant to do that?

Screen Shot 2020-07-27 at 12 06 50 PM

@andreancardona
Copy link
Contributor Author

If you click on the main section when the sidenav is open, there's like a focus outline on part of it. Is it meant to do that?

Screen Shot 2020-07-27 at 12 06 50 PM

@jnm2377 from what I can tell that's what it currently does / that is the current behavior - I'm not sure though 🤷‍♀️

@jnm2377
Copy link
Contributor

jnm2377 commented Jul 27, 2020

ahhh gotcha @andreancardona hmm.. I'm not sure we want a focus outline... but since it's an existing issue, I'm fine with merging :)

@andreancardona andreancardona merged commit 949f3c0 into carbon-design-system:main Jul 27, 2020
@andreancardona andreancardona changed the title fix: 943-audit-avt1-homepage-banner-role fix: 943-audit-avt1-homepage-banner-role Jul 28, 2020
@andreancardona andreancardona changed the title fix: 943-audit-avt1-homepage-banner-role fix: 943-audit-avt1-homepage-content-not-in-landmark Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit-avt1-homepage: content not within landmark
3 participants