Update to cardano-node 1.35-rc2 #3280

Anviking · 2022-05-20T12:45:20Z

Overview

Updates dependencies to target cardano-node 1.35-rc2
Adds support to make the wallet mostly work in Babbage
Rework of nix setup: we now derive nix files from cabal.project rather than the weird stack.yaml-based approach we had before.

Detailed todo-list

Things we need eventually, but not strictly for this PR

Update to final 1.35 tag once it is released - can be done in separate PR

Run existing integration tests on both Alonzo and Babbage eras in CI

Depend on cardano-addresses with aeson2 support merged, tagged and released

Depend on a cardano-sl-x509 where aeson 2 support is merged to master

Consider appropriateness Tx deserialisation hack 9e2568e

Moved to jira tasks in https://input-output.atlassian.net/browse/ADP-1538

Comments

Includes #3258, #3293

Issue Number

ADP-1744

jonathanknowles

Hi @Anviking

Just leaving some suggestions (See comments.)

lib/core/test/unit/Cardano/Api/GenSpec.hs

lib/core/src/Network/Wai/Middleware/Logging.hs

lib/core/test/unit/Cardano/Api/GenSpec.hs

lib/core/test/unit/Cardano/Wallet/Api/TypesSpec.hs

lib/shelley/src/Cardano/Wallet/Shelley/Compatibility.hs

lib/shelley/src/Cardano/Wallet/Shelley/Launch/Cluster.hs

lib/shelley/src/Cardano/Wallet/Shelley/Transaction.hs

lib/shelley/src/Cardano/Wallet/Shelley/Compatibility.hs

cabal.project

We can avoid a "stringly-typed" constructor here by reusing the `TranslationError` type provided by `Cardano.Ledger.Alonzo.TxInfo`.

jonathanknowles

This looks reasonable to me.

I just have a few questions! (See comments.)

lib/cli/test/unit/Cardano/CLISpec.hs

jonathanknowles · 2022-06-16T01:47:54Z

flake.nix

@@ -33,7 +33,7 @@
  ############################################################################

  inputs = {
-    nixpkgs.follows = "haskellNix/nixpkgs-2111";
+    nixpkgs.follows = "haskellNix/nixpkgs-unstable";


Do we know what the implications of following nixpkgs-unstable are?

For example, will it lead to more frequent fetching of dependencies? (i.e., when entering a nix develop shell, will we have to download dependencies more frequently than before?)

Do we know what the implications of following nixpkgs-unstable are?

I don't entirely, but it seems to be needed, and I believe the consensus is that it's "fine".

(i.e., when entering a nix develop shell, will we have to download dependencies more frequently than before?)

No, the dependencies are locked in flake.lock, and we'd only need to download new dependencies when we bump... haskell.nix I think.

jonathanknowles · 2022-06-16T01:53:41Z

lib/core/src/Cardano/Api/Gen.hs

            , Api.txOuts
+            , Api.txTotalCollateral = TxTotalCollateralNone
+            , Api.txReturnCollateral = TxReturnCollateralNone


@Anviking @paweljakubas

We generate a value for txIns here. Do we need a task to generate values for txInsCollateral, txTotalCollateral, and txReturnCollateral, and txInsReference?

Hm:

txTotalCollateral - might be added as part of ADP-1653

txReturnCollateral - might be added as part of ADP-1653

txInsReference - relevant to ADP-1655

txInsCollateral - ~~I have added it to https://input-output.atlassian.net/browse/ADP-1374~~

I don't think their addition should be strictly required in ADP-1653 or ADP-1655 respectively, and at the same time I suspect creating a new ticket at the moment might just add noise.

0902c88

And actually we are already generating txInsCollateral, just at a later step (added a note).

lib/core/src/Cardano/Wallet/Transaction.hs

- Link usages of PackageImports to ADP-1910, where we explain why we used PackageImports and how we might get rid of it in future.

- Try bumping haskell.nix to fix remaining issues with windows cross-compile builds.

By treating `TimeTranslationPastHorizon` differently we can return the same api error code as we used to, and which is arguably more descriptive.

Anviking · 2022-06-16T16:22:12Z

I think it would be good to have #3328 or something similar before merging for the sake of removing stack.yaml and having an easy way of updating the sha256 hashes — @sevanspowell objections, thoughts or do you see another way?

3328: Completely drop stack.yaml and sha256map.nix r=sevanspowell a=Anviking - It seems `stack.yaml` and `sha256map.nix` can just be removed and replaced with [`checkCabalProject`](https://github.com/input-output-hk/iohk-nix/search?q=checkCabalProject) and `--sha256` lines in `cabal.project` ### Tested manually Sanity checking that it works similarly to with the stack and sha256map-based approach: #### Revision in cabal.project changed ``` $ ./nix/regenerate.sh Changes required to cabal.project --- cabal.project.old 2022-06-13 20:35:27.437617302 +0200 +++ cabal.project 2022-06-13 20:36:37.049474850 +0200 `@@` -90,7 +90,7 `@@` type: git location: https://github.com/input-output-hk/cardano-addresses tag: 4ff9c4022d4d257053c96509f20c9d931ab8f57b - --sha256: 0iqzppqqb1xqnp55yd0xil9qfy8fz8474w834nmfg2w692bynyb9 + --sha256: 0q93a2r4v8d3nfvix6yjmbh3v77hz2hpp6p11krklvnvw7h00lfk subdir: command-line core ``` (exit code 1) #### Invalid SHA256 hash ``` $ ./nix/regenerate.sh Changes required to cabal.project --- cabal.project.old 2022-06-13 20:42:25.934613264 +0200 +++ cabal.project 2022-06-13 20:43:38.737611148 +0200 `@@` -299,7 +299,7 `@@` type: git location: https://github.com/haskell-works/hw-aeson tag: d99d2f3e39a287607418ae605b132a3deb2b753f - --sha256: 0vxqcwjg9q37wbwi27y9ba5163lzfz51f1swbi0rp681yg63zvn4 + --sha256: 1vxqcwjg9q37wbwi27y9ba5163lzfz51f1swbi0rp681yg63zvn4 ``` (exit code 1)  #### Invalid SHA256 hash in `cabal.project` + `direnv reload` The corresponding change on master would be having an incorrect hash in `sha256map.nix` and calling `direnv reload`. And if you on master changed a revision in `stack.yaml`, `direnv reload` would still work, only `./nix/regenerate.sh` wouldn't. Because `nix shell` now is derived directly from `cabal.project` without intermediate state like sha256map.nix, `direnv reload` now fails directly. ```bash direnv reload (4s 207ms) direnv: loading ~/IOHK/cardano-wallet/.envrc direnv: using flake warning: Git tree '/Users/anviking/IOHK/cardano-wallet' is dirty trace: To make project.plan-nix for cardano-wallet a fixed-output derivation but not materialized, set `plan-sha256` to the output of the 'calculateMaterializedSha' script in 'passthru'. trace: To materialize project.plan-nix for cardano-wallet entirely, pass a writable path as the `materialized` argument and run the 'updateMaterialized' script in 'passthru'. direnv: ([/usr/local/bin/direnv export fish]) is taking a while to execute. Use CTRL-C to give up. error: hash mismatch in fixed-output derivation '/nix/store/icv2hd3bghfg80fvppdnjp0b0h1wji7x-hw-aeson-d99d2f3.drv': specified: sha256-xO4/zPMBmZtBXFwHF8p3nw4TilrJHxH54mfg9CRnuG8= got: sha256-xO4/zPMBmZtBXFwHF8p3nw4TilrJHxH54mfg9CRnuO8= error: 1 dependencies of derivation '/nix/store/493wcz8r85zbq5yaimm74ldnwz62m6in-source-repository-package.drv' failed to build error: 1 dependencies of derivation '/nix/store/2ja2788s8ivgsv2mcrb2b9pdl7b894dx-cardano-wallet-plan-to-nix-pkgs.drv' failed to build (use '--show-trace' to show detailed location information) warning: Git tree '/Users/anviking/IOHK/cardano-wallet' is dirty direnv: renewed cache direnv: export +XDG_DATA_DIRS ``` ### Comments Targets #3280 ### Issue Number ADP-1744  Co-authored-by: Johannes Lund <johannes.lund@iohk.io>

…etely-drop-stack.yaml Completely drop stack.yaml and sha256map.nix

sevanspowell · 2022-06-17T07:15:51Z

I think it would be good to have #3328 or something similar before merging for the sake of removing stack.yaml and having an easy way of updating the sha256 hashes — @sevanspowell objections, thoughts or do you see another way?

No objection! Nice work 🥳 I've merged #3328.

Anviking · 2022-06-17T08:03:08Z

bors r+

3280: Update to cardano-node 1.35-rc2 r=Anviking a=Anviking ### Overview - Updates dependencies to target `cardano-node 1.35-rc2` - Adds support to make the wallet _mostly_ work in Babbage - Rework of nix setup: we now derive nix files from `cabal.project` rather than the weird `stack.yaml`-based approach we had before. ### Detailed todo-list - [x] Get nix happy with the new dependencies - [x] Make `cabal build all` work with modulo warnings - [x] Update to more recent revisions - [x] Fix compilation in tests again - [x] Make `cabal build all` work with _no_ warnings - [x] Fix puzzling persistent TH name shadowing warnings -> fixed by sam? - [x] Ensure existing tests pass - [x] unit - [x] Look closer at balanceTx golden unit failure after first seeing if balanceTx integration tests pass on both alonzo and Babbage - [x] Integration (on alonzo like on master) - [x] Was blocked by readTVar, fixed with input-output-hk/io-sim#6 (review) - [x] Fix failures relating to Babbage era -> fixed with a hack 9e2568e - [x] Fix cardano-wallet-core Aeson failures - [x] More closely review code-changes - [x] Clean up git commit history - [x] Flatten merge commits - [x] Squash back-and-forth nix and revision changes - [x] Rebase off master - [x] Ensure revisions in stack.yaml and cabal.project are updated consistently - Alternatively remove `stack.yaml` and ensure ./nix/regenerate.sh still works and that we know how to update sha256map.nix — #3328 but without the sha256map.nix - [x] Ensure CI is completely green: [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-3280), ADP-1888 - There may be CI specific problems with nix, windows and more (there probably are) - [x] fix hydra wine TH error e.g. `$(TH.lift =<< TH.runIO (readFile "app/foo.txt"))` - seems relevant input-output-hk/haskell.nix#1508 - seems gone now - [x] `Ambiguous module name` https://hydra.iohk.io/build/15469467 - https://input-output-rnd.slack.com/archives/C48HA39RS/p1654388106509579 - Bumping Haskell.nix again should help? - Didn't seem like it worked... - https://input-output-rnd.slack.com/archives/CAP8NM7N0/p1654828014483969 - [x] Remove-iserv problem https://hydra.iohk.io/build/15604435 - Update from Hamish https://input-output-rnd.slack.com/archives/CAP8NM7N0/p1655213059547499?thread_ts=1654828014.483969&cid=CAP8NM7N0 - [x] Docs shell - we don't need explicit emanote input in nix config - [x] Profiled shell: `recursionzmschemeszm5zi2zi2zi2zm6NC6xZZx2tI3826DrVhqI9v_DataziFunctorziFoldableziTH_zdfMakeBaseFunctorNamezuzdcmakeBaseFunctor_closure` https://hydra.iohk.io/build/15694577/nixlog/2/tail - [x] musl cli goldens https://hydra.iohk.io/build/15694618/nixlog/82 - [x] `hie-bios: hie-bios: this operation requires -fexternal-interpreter - [x] `Ambiguous module name 'Options.Applicative':` in HLS - now we at least have an ugly `-XPackageImport` workaround. - [x] Update node revision in readme.md ### Things we need eventually, but not strictly for this PR > - Update to final 1.35 tag once it is released - can be done in separate PR > - Run existing integration tests on both Alonzo and Babbage eras in CI > - Depend on cardano-addresses with aeson2 support merged, tagged and released > - Depend on a cardano-sl-x509 where aeson 2 support is merged to master > - Consider appropriateness Tx deserialisation hack 9e2568e Moved to jira tasks in https://input-output.atlassian.net/browse/ADP-1538 ### Comments Includes #3258, #3293  ### Issue Number ADP-1744  Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: Pawel Jakubas <jakubas.pawel@gmail.com> Co-authored-by: Samuel Evans-Powell <mail@sevanspowell.net> Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>

iohk-bors · 2022-06-17T12:13:15Z

Timed out.

Anviking · 2022-06-17T14:14:36Z

bors r+

3280: Update to cardano-node 1.35-rc2 r=Anviking a=Anviking ### Overview - Updates dependencies to target `cardano-node 1.35-rc2` - Adds support to make the wallet _mostly_ work in Babbage - Rework of nix setup: we now derive nix files from `cabal.project` rather than the weird `stack.yaml`-based approach we had before. ### Detailed todo-list - [x] Get nix happy with the new dependencies - [x] Make `cabal build all` work with modulo warnings - [x] Update to more recent revisions - [x] Fix compilation in tests again - [x] Make `cabal build all` work with _no_ warnings - [x] Fix puzzling persistent TH name shadowing warnings -> fixed by sam? - [x] Ensure existing tests pass - [x] unit - [x] Look closer at balanceTx golden unit failure after first seeing if balanceTx integration tests pass on both alonzo and Babbage - [x] Integration (on alonzo like on master) - [x] Was blocked by readTVar, fixed with input-output-hk/io-sim#6 (review) - [x] Fix failures relating to Babbage era -> fixed with a hack 9e2568e - [x] Fix cardano-wallet-core Aeson failures - [x] More closely review code-changes - [x] Clean up git commit history - [x] Flatten merge commits - [x] Squash back-and-forth nix and revision changes - [x] Rebase off master - [x] Ensure revisions in stack.yaml and cabal.project are updated consistently - Alternatively remove `stack.yaml` and ensure ./nix/regenerate.sh still works and that we know how to update sha256map.nix — #3328 but without the sha256map.nix - [x] Ensure CI is completely green: [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-3280), ADP-1888 - There may be CI specific problems with nix, windows and more (there probably are) - [x] fix hydra wine TH error e.g. `$(TH.lift =<< TH.runIO (readFile "app/foo.txt"))` - seems relevant input-output-hk/haskell.nix#1508 - seems gone now - [x] `Ambiguous module name` https://hydra.iohk.io/build/15469467 - https://input-output-rnd.slack.com/archives/C48HA39RS/p1654388106509579 - Bumping Haskell.nix again should help? - Didn't seem like it worked... - https://input-output-rnd.slack.com/archives/CAP8NM7N0/p1654828014483969 - [x] Remove-iserv problem https://hydra.iohk.io/build/15604435 - Update from Hamish https://input-output-rnd.slack.com/archives/CAP8NM7N0/p1655213059547499?thread_ts=1654828014.483969&cid=CAP8NM7N0 - [x] Docs shell - we don't need explicit emanote input in nix config - [x] Profiled shell: `recursionzmschemeszm5zi2zi2zi2zm6NC6xZZx2tI3826DrVhqI9v_DataziFunctorziFoldableziTH_zdfMakeBaseFunctorNamezuzdcmakeBaseFunctor_closure` https://hydra.iohk.io/build/15694577/nixlog/2/tail - [x] musl cli goldens https://hydra.iohk.io/build/15694618/nixlog/82 - [x] `hie-bios: hie-bios: this operation requires -fexternal-interpreter - [x] `Ambiguous module name 'Options.Applicative':` in HLS - now we at least have an ugly `-XPackageImport` workaround. - [x] Update node revision in readme.md ### Things we need eventually, but not strictly for this PR > - Update to final 1.35 tag once it is released - can be done in separate PR > - Run existing integration tests on both Alonzo and Babbage eras in CI > - Depend on cardano-addresses with aeson2 support merged, tagged and released > - Depend on a cardano-sl-x509 where aeson 2 support is merged to master > - Consider appropriateness Tx deserialisation hack 9e2568e Moved to jira tasks in https://input-output.atlassian.net/browse/ADP-1538 ### Comments Includes #3258, #3293  ### Issue Number ADP-1744  Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: Pawel Jakubas <jakubas.pawel@gmail.com> Co-authored-by: Samuel Evans-Powell <mail@sevanspowell.net> Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>

iohk-bors · 2022-06-17T14:26:40Z

Build failed:

buildkite/cardano-wallet

test/unit/Main.hs:1:1: error:
--
  | `hspec-discover' failed in phase `Haskell pre-processor'. (Exit code: 127)
  | \|
  | 1 \| {-# OPTIONS_GHC -F -pgmF hspec-discover #-}
  | \| ^

Anviking · 2022-06-17T14:39:14Z

bors r+

3280: Update to cardano-node 1.35-rc2 r=Anviking a=Anviking ### Overview - Updates dependencies to target `cardano-node 1.35-rc2` - Adds support to make the wallet _mostly_ work in Babbage - Rework of nix setup: we now derive nix files from `cabal.project` rather than the weird `stack.yaml`-based approach we had before. ### Detailed todo-list - [x] Get nix happy with the new dependencies - [x] Make `cabal build all` work with modulo warnings - [x] Update to more recent revisions - [x] Fix compilation in tests again - [x] Make `cabal build all` work with _no_ warnings - [x] Fix puzzling persistent TH name shadowing warnings -> fixed by sam? - [x] Ensure existing tests pass - [x] unit - [x] Look closer at balanceTx golden unit failure after first seeing if balanceTx integration tests pass on both alonzo and Babbage - [x] Integration (on alonzo like on master) - [x] Was blocked by readTVar, fixed with input-output-hk/io-sim#6 (review) - [x] Fix failures relating to Babbage era -> fixed with a hack 9e2568e - [x] Fix cardano-wallet-core Aeson failures - [x] More closely review code-changes - [x] Clean up git commit history - [x] Flatten merge commits - [x] Squash back-and-forth nix and revision changes - [x] Rebase off master - [x] Ensure revisions in stack.yaml and cabal.project are updated consistently - Alternatively remove `stack.yaml` and ensure ./nix/regenerate.sh still works and that we know how to update sha256map.nix — #3328 but without the sha256map.nix - [x] Ensure CI is completely green: [Hydra jobset](https://hydra.iohk.io/jobset/Cardano/cardano-wallet-pr-3280), ADP-1888 - There may be CI specific problems with nix, windows and more (there probably are) - [x] fix hydra wine TH error e.g. `$(TH.lift =<< TH.runIO (readFile "app/foo.txt"))` - seems relevant input-output-hk/haskell.nix#1508 - seems gone now - [x] `Ambiguous module name` https://hydra.iohk.io/build/15469467 - https://input-output-rnd.slack.com/archives/C48HA39RS/p1654388106509579 - Bumping Haskell.nix again should help? - Didn't seem like it worked... - https://input-output-rnd.slack.com/archives/CAP8NM7N0/p1654828014483969 - [x] Remove-iserv problem https://hydra.iohk.io/build/15604435 - Update from Hamish https://input-output-rnd.slack.com/archives/CAP8NM7N0/p1655213059547499?thread_ts=1654828014.483969&cid=CAP8NM7N0 - [x] Docs shell - we don't need explicit emanote input in nix config - [x] Profiled shell: `recursionzmschemeszm5zi2zi2zi2zm6NC6xZZx2tI3826DrVhqI9v_DataziFunctorziFoldableziTH_zdfMakeBaseFunctorNamezuzdcmakeBaseFunctor_closure` https://hydra.iohk.io/build/15694577/nixlog/2/tail - [x] musl cli goldens https://hydra.iohk.io/build/15694618/nixlog/82 - [x] `hie-bios: hie-bios: this operation requires -fexternal-interpreter - [x] `Ambiguous module name 'Options.Applicative':` in HLS - now we at least have an ugly `-XPackageImport` workaround. - [x] Update node revision in readme.md ### Things we need eventually, but not strictly for this PR > - Update to final 1.35 tag once it is released - can be done in separate PR > - Run existing integration tests on both Alonzo and Babbage eras in CI > - Depend on cardano-addresses with aeson2 support merged, tagged and released > - Depend on a cardano-sl-x509 where aeson 2 support is merged to master > - Consider appropriateness Tx deserialisation hack 9e2568e Moved to jira tasks in https://input-output.atlassian.net/browse/ADP-1538 ### Comments Includes #3258, #3293  ### Issue Number ADP-1744  Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: Pawel Jakubas <jakubas.pawel@gmail.com> Co-authored-by: Samuel Evans-Powell <mail@sevanspowell.net> Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>

iohk-bors · 2022-06-17T15:20:15Z

Build failed:

buildkite/cardano-wallet

Anviking · 2022-06-17T15:32:09Z

bors r+

iohk-bors · 2022-06-17T17:54:14Z

Build succeeded:

Anviking self-assigned this May 20, 2022

Anviking force-pushed the anviking/ADP-1744/node-1.35 branch 8 times, most recently from ab674d3 to 8989644 Compare May 24, 2022 14:33

Anviking force-pushed the anviking/ADP-1744/node-1.35 branch from 085df45 to 3b9f866 Compare May 30, 2022 15:53

Anviking mentioned this pull request May 30, 2022

Bump aeson and cardano node #3258

Closed

jonathanknowles reviewed May 31, 2022

View reviewed changes

Anviking mentioned this pull request Jun 7, 2022

Upgrade to aeson 2 IntersectMBO/cardano-addresses#189

Closed

Anviking force-pushed the anviking/ADP-1744/node-1.35 branch 2 times, most recently from 5beaea0 to 94c663f Compare June 7, 2022 16:51

Anviking mentioned this pull request Jun 7, 2022

Update to node 1.35.0-rc2 #3315

Merged

3 tasks

Anviking force-pushed the anviking/ADP-1744/node-1.35 branch 3 times, most recently from ae261c8 to f8b0c33 Compare June 10, 2022 15:15

Anviking changed the title ~~WIP: Prepare for cardano-node 1.35~~ Update to cardano-node 1.35-rc2 Jun 10, 2022

Anviking force-pushed the anviking/ADP-1744/node-1.35 branch 8 times, most recently from be95850 to 135f18c Compare June 13, 2022 13:14

michalrus mentioned this pull request Jun 13, 2022

[DDW-1110] Use Vasil-supported cardano-wallet input-output-hk/daedalus#3001

Merged

28 tasks

Anviking commented Jun 14, 2022

View reviewed changes

cabal.project Outdated Show resolved Hide resolved

jonathanknowles added 2 commits June 16, 2022 03:26

Explicitly import constructors for BasicFailure.

679f464

Use TranslationError within ErrAssignRedeemersTranslationError.

035fd11

We can avoid a "stringly-typed" constructor here by reusing the `TranslationError` type provided by `Cardano.Ledger.Alonzo.TxInfo`.

jonathanknowles force-pushed the anviking/ADP-1744/node-1.35 branch from 136e20b to 035fd11 Compare June 16, 2022 03:31

jonathanknowles approved these changes Jun 16, 2022

View reviewed changes

Link usage of PackageImports to ticket explaining reasoning

604f06e

- Link usages of PackageImports to ADP-1910, where we explain why we used PackageImports and how we might get rid of it in future.

sevanspowell force-pushed the anviking/ADP-1744/node-1.35 branch from 2fd77d5 to 604f06e Compare June 16, 2022 05:29

sevanspowell and others added 4 commits June 16, 2022 17:14

Try bumping haskell.nix

dd6e174

- Try bumping haskell.nix to fix remaining issues with windows cross-compile builds.

Update node version in readme compatibility matrix

b5859ff

Replace nix/sha256map and stack.yaml with checkCabalProject

8eea1d3

Improve TODOs and linking to tasks in Api.Gen module

0902c88

Anviking force-pushed the anviking/ADP-1744/node-1.35 branch from 843a407 to 0902c88 Compare June 16, 2022 13:48

Minimize API changes w.r.t TimeTranslationPastHorizon

896c068

By treating `TimeTranslationPastHorizon` differently we can return the same api error code as we used to, and which is arguably more descriptive.

Merge pull request #3328 from input-output-hk/anviking/ADP-1744/compl…

0129872

…etely-drop-stack.yaml Completely drop stack.yaml and sha256map.nix

iohk-bors bot merged commit df24232 into master Jun 17, 2022

iohk-bors bot deleted the anviking/ADP-1744/node-1.35 branch June 17, 2022 17:54

Anviking mentioned this pull request Jul 7, 2022

Support Aeson 2 #3187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to cardano-node 1.35-rc2 #3280

Update to cardano-node 1.35-rc2 #3280

Anviking commented May 20, 2022 •

edited

Loading

jonathanknowles left a comment •

edited

Loading

jonathanknowles left a comment

jonathanknowles Jun 16, 2022 •

edited

Loading

Anviking Jun 16, 2022

jonathanknowles Jun 16, 2022

Anviking Jun 16, 2022 •

edited

Loading

Anviking Jun 16, 2022

Anviking Jun 16, 2022

Anviking commented Jun 16, 2022 •

edited

Loading

sevanspowell commented Jun 17, 2022

Anviking commented Jun 17, 2022

iohk-bors bot commented Jun 17, 2022

Anviking commented Jun 17, 2022

iohk-bors bot commented Jun 17, 2022 •

edited by Anviking

Loading

Anviking commented Jun 17, 2022

iohk-bors bot commented Jun 17, 2022

Anviking commented Jun 17, 2022

iohk-bors bot commented Jun 17, 2022

Update to cardano-node 1.35-rc2 #3280

Update to cardano-node 1.35-rc2 #3280

Conversation

Anviking commented May 20, 2022 • edited Loading

Overview

Detailed todo-list

Things we need eventually, but not strictly for this PR

Comments

Issue Number

jonathanknowles left a comment • edited Loading

Choose a reason for hiding this comment

jonathanknowles left a comment

Choose a reason for hiding this comment

jonathanknowles Jun 16, 2022 • edited Loading

Choose a reason for hiding this comment

Anviking Jun 16, 2022

Choose a reason for hiding this comment

jonathanknowles Jun 16, 2022

Choose a reason for hiding this comment

Anviking Jun 16, 2022 • edited Loading

Choose a reason for hiding this comment

Anviking Jun 16, 2022

Choose a reason for hiding this comment

Anviking Jun 16, 2022

Choose a reason for hiding this comment

Anviking commented Jun 16, 2022 • edited Loading

sevanspowell commented Jun 17, 2022

Anviking commented Jun 17, 2022

iohk-bors bot commented Jun 17, 2022

Anviking commented Jun 17, 2022

iohk-bors bot commented Jun 17, 2022 • edited by Anviking Loading

Anviking commented Jun 17, 2022

iohk-bors bot commented Jun 17, 2022

Anviking commented Jun 17, 2022

iohk-bors bot commented Jun 17, 2022

Anviking commented May 20, 2022 •

edited

Loading

jonathanknowles left a comment •

edited

Loading

jonathanknowles Jun 16, 2022 •

edited

Loading

Anviking Jun 16, 2022 •

edited

Loading

Anviking commented Jun 16, 2022 •

edited

Loading

iohk-bors bot commented Jun 17, 2022 •

edited by Anviking

Loading