-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to cardano-node 1.35-rc2 #3280
Merged
Merged
Changes from all commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
272d1dc
Bump cardano-node, use aeson 2, and use cabal as source of truth
Anviking 983eafb
Try increasing node-to-client version
Anviking b2720d3
adjust Primitive.Types.Tx module
paweljakubas abd32e1
fromBabbageTxBodyAndAux - backbone
paweljakubas f2cc90e
fromBabbageValidatedTx
paweljakubas bea4c32
fromBabbageTx
paweljakubas e8ee78b
fromBabbageBlock
paweljakubas e4fbf0d
numberOfTransactionsInBlock
paweljakubas c4847f6
handle collateralOutput
paweljakubas e51bc23
shelley unit test fixes - part 1
paweljakubas 2d3c19a
Tweak error message in toPaymentHash
Anviking 131a7ac
some more fillings
paweljakubas 25291b2
towards shelley core unit tests - part 1
paweljakubas c6aba89
Bump io-sim to fix readTVar issue
Anviking 39e5ccb
Hack: tweak deserialisation preference to make integration tests pass
Anviking df4588c
Use Plutus.defaultCostModelParams in balanceTx tests
Anviking a359d24
Restrict persistent to version < 2.13.3.4
sevanspowell ac70467
Upgrade version of cardano-addresses
sevanspowell b208f55
Make autoconf tools + libsecp256k1 available in non-Nix cabal build
sevanspowell 1f78c7a
fix genTxIx and genCertIx
paweljakubas 4d056e3
try with genSlotNo
paweljakubas e9d5863
adjust ApiNetworkParameters in swagger
paweljakubas 0e83c77
Upgrade version of cardano-addresses - Stack.yaml
sevanspowell 7545e4f
Eliminate implicit imports from `Cardano.Api.GenSpec`.
jonathanknowles 7034966
Bump haskell.nix
Anviking 2080bf0
LoggingSpec fix
paweljakubas 8582d47
reuse fromLedgerPParams from cardano-api - part 1
paweljakubas 7ca11a4
clean fromLedgerAlonzoPParams
paweljakubas cfb48d9
reuse fromLedgerPParams from cardano-api - part 2
paweljakubas 272eb1a
assignScriptRedeemers refactoring
paweljakubas ea26d90
libsodium.dll is now automatically installed
sevanspowell 5a73357
Regenerate golden JSON files for all API types.
jonathanknowles bf60a34
Update node to 1.35.0-rc2
Anviking ba6f9b4
handle translation error
paweljakubas 7fcaa0c
Bump haskell.nix again
Anviking e47526a
Add module `Cardano.Ledger.Credential.Safe`.
jonathanknowles f55a693
Add `genSlotNo32` and use it within `genPtr`.
jonathanknowles c44240c
Add `genSlotNo32Coverage` and use it in `genPtrCoverage`.
jonathanknowles 6aab92b
Add roundtrip test for `safePtr` and `safeUnwrapPtr`.
jonathanknowles 49a9ab3
Miscellaneous import fixes.
jonathanknowles 799e97f
Add statement of properties to `Cardano.Ledger.Credential.Safe`.
jonathanknowles 05bca3f
Fix haskell-language-server build
sevanspowell c8013e5
Update pingPong_2/golden file: fee seems to be smaller
Anviking 5039323
rebase fixup: remove redundant Small import in Cardano.Api.Gen
Anviking 74fc715
rebase fixup: aeson 2 changes in Blockfrost module
Anviking a753f21
tmp: disable nix regeneration of sha256map
Anviking a51b6c5
tweak formatting
Anviking 7478b20
fix hlint
Anviking 867bfa2
Try updating haskell.nix
Anviking 7dc6420
Try to fix nix `error: attribute 'defaultPackage' missing`
Anviking 5c6d4c4
tmp: try removing libsodium-vrf addition from nix
Anviking f01febb
haskell.nix changes
sevanspowell f903038
try setting reinstallableLibGhc to true
Anviking 99d6d14
Remove explicit emanote input from flake.nix
Anviking 840c0ce
Regenerate cli goldens (only whitespace changes)
Anviking 7c6b18a
Add -fexternal-interpreter GHC option to plutus-core when profiling
sevanspowell 4ae6e2c
Remove now redundant dependency on hw-aeson
Anviking 38aa495
Remove unused ErrAssignRedeemersPastHorizon for now
Anviking 64d58ab
Re-format a few lines which are too long
Anviking b7e9e58
Apply suggestion: use \case in shelleyBasedToCardanoEra
Anviking 1562767
hie-bios: Set reinstallableLibGhc to false
sevanspowell 4cbf834
Workaround hie-direnv.yaml errors
Anviking 4ff9c77
Miscellanous formatting fixes.
jonathanknowles 679f464
Explicitly import constructors for `BasicFailure`.
jonathanknowles 035fd11
Use `TranslationError` within `ErrAssignRedeemersTranslationError`.
jonathanknowles 604f06e
Link usage of PackageImports to ticket explaining reasoning
sevanspowell dd6e174
Try bumping haskell.nix
sevanspowell b5859ff
Update node version in readme compatibility matrix
Anviking 8eea1d3
Replace nix/sha256map and stack.yaml with `checkCabalProject`
Anviking 0902c88
Improve TODOs and linking to tasks in Api.Gen module
Anviking 896c068
Minimize API changes w.r.t `TimeTranslationPastHorizon`
Anviking 0129872
Merge pull request #3328 from input-output-hk/anviking/ADP-1744/compl…
sevanspowell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧐 Not sure where this came from nor the implications of it. Do we want it?
edit: it's from #3293
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the node repo has docs which says
and has
systemd = !pkgs.stdenv.hostPlatform.isMusl
in its nix config.With this change we have
flags: +systemd
but which can be overridden to false if isMusl, which should be equivalent to the node's= !isMusl
.So while I don't grasp the implications, I'd guess this is fine.