Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitmoji-proposal.yml #1198

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Update gitmoji-proposal.yml #1198

merged 4 commits into from
Nov 16, 2022

Conversation

vhoyer
Copy link
Collaborator

@vhoyer vhoyer commented Nov 15, 2022

Closes #1120

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gitmoji ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 0:29AM (UTC)

@vhoyer
Copy link
Collaborator Author

vhoyer commented Nov 15, 2022

id: emoji-what-how
attributes:
label: Does this emoji fall into the "how" category?
description: Explain the creation of this emoji, what this is and when it should be used
placeholder: We are trying to always describe/categorize the "what" has been done in one particular commit (:white_check_mark:, :lock:, :zap:...), not the "how" it was done (the exceptions being :hankey:, :beers:)
description: We are trying to always describe/categorize the "what" has been done in one particular commit (:white_check_mark:, :lock:, :zap:...), not the "how" it was done (the exceptions being :hankey:, :beers:)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this:

Suggested change
description: We are trying to always describe/categorize the "what" has been done in one particular commit (:white_check_mark:, :lock:, :zap:...), not the "how" it was done (the exceptions being :hankey:, :beers:)
description: We are trying to always describe/categorize "what" has been done in one particular commit (:white_check_mark:, :lock:, :zap:...), not "how" it was done (the exceptions being :hankey:, :beers:)

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks ❤️

@carloscuesta carloscuesta merged commit 412acfa into master Nov 16, 2022
@carloscuesta carloscuesta deleted the vhoyer-patch-1 branch November 16, 2022 17:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue template
2 participants