Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitmoji-proposal.yml #1198

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Update gitmoji-proposal.yml #1198

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c61abd
Update gitmoji-proposal.yml
vhoyer Nov 15, 2022
c91830e
:pencil2: (issue template): Fix grammar and markup
vhoyer Nov 16, 2022
4502b5d
:memo: (issue template): Improve what/how question display
vhoyer Nov 16, 2022
bd68920
:memo: (issue template): display examples on a table
vhoyer Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/ISSUE_TEMPLATE/gitmoji-proposal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,14 @@ body:
- "No ❌"
validations:
required: true
- type: textarea
- type: checkboxes
id: emoji-what-how
attributes:
label: Does this emoji fall into the "how" category?
description: Explain the creation of this emoji, what this is and when it should be used
placeholder: We are trying to always describe/categorize the "what" has been done in one particular commit (:white_check_mark:, :lock:, :zap:...), not the "how" it was done (the exceptions being :hankey:, :beers:)
description: We are trying to always describe/categorize the "what" has been done in one particular commit (:white_check_mark:, :lock:, :zap:...), not the "how" it was done (the exceptions being :hankey:, :beers:)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this:

Suggested change
description: We are trying to always describe/categorize the "what" has been done in one particular commit (:white_check_mark:, :lock:, :zap:...), not the "how" it was done (the exceptions being :hankey:, :beers:)
description: We are trying to always describe/categorize "what" has been done in one particular commit (:white_check_mark:, :lock:, :zap:...), not "how" it was done (the exceptions being :hankey:, :beers:)

options:
- label: This proposal do not describe "how" a commit was made, but do in fact describe "what" is the contents of the commit about.
required: true
validations:
required: true
- type: textarea
Expand All @@ -74,4 +76,4 @@ body:
- label: Read the [Contributing Guide](https://github.com/carloscuesta/gitmoji/blob/master/.github/CONTRIBUTING.md).
required: true
- label: Check that there isn't already an issue requesting the emoji.
required: true
required: true