STY: Sync with carpentries remote styles #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will address #544
... by using GFM (GitHub-flavored Markdown) parser (`kramdown-parser-gfm`) instead of the default one (`kramdown`). The default one fails to produce an AST (Abstract Syntax Tree) when there is no blank line before the line with the opening code fence. Related: - gettalong/kramdown#530 - Python-Markdown/markdown#807 Fixes: carpentries/styles#543
Fix Kramdown parser crash
...to make them distinguishable from regular text. And for accessibility!
lesson_check.py allow for missing life_cycle
There are times when the AST is malformed and does not emit a class for the code element. We do not want the parser to crash when this happens, but we also want to notify ourselves that the AST is malformed. This should not result in an error because as we saw in carpentries/styles#543, the parser itself can cause these malformations when the lesson itself renders well. Even though we fixed the previous issue with an updated parser, problems still persist: swcarpentry/r-novice-gapminder#696 (comment) I fully admit that this is a kludge.
I've removed the print condition, because it will just result in an error no matter what (sigh)
Add catch for None type code block in lesson_check
Makefile: fix 'bundle config' command flags
Clean up: 1. `.vendor` directory where Bundler installs all the gems. 2. `.bundle` directory where Bundler stores its settings. 3. `Gemfile.lock` file generated by the Bundler.
Makefile: silence Docker commands
Specifically, set CRAN repository to https://cran.rstudio.com
Fix GitHub actions for lessons in Rmarkdown
Makefile: fix up PHONY targets
add class for images with a drop shadow
This will fix carpentries/styles#576
Update contributing guide
Will be useful for HPC-Carpentry lessons, GPU programming lesson as well as Julia lessons which are currently in the incubator.
Improved relative_root_path
bin/lesson_check.py: one more fix for using_remote_theme()
Template workflow: add two more lessons
Current syncing procedure that used in the Template workflow fails for: 1. Lessons that are, in fact, nsync with the styles repo. 2. For lessons that use The Carpentries' remote theme and have deleted some of the files. This PR makes this step a little bit more intelligent and takes into account the above two scenarios.
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Template workflow: smarter syncing with the styles repo
It should've been removed in 7e835fd.
bin/lesson_check.py: allow comments and empty lines in links.md Fixes carpentries/styles#581
bin/lesson_check.py: use proper function
Allow lines that contain a single image or a single link to go over the suggested line length limit.
bin/lesson_check.py: allow exceptions to line length limit Fixes carpentries/styles#591
This change hardens the pattern that matches single-line
image or link:
1. It extends the pattern to be matched in a heading
2. It allows the line to contain {: ...} customizations
3. It allows the line to end with \
lesson_check.py: harden single-line image/link pattern Fixes carpentries/styles#591
|
Deploy preview for carpentries-intromri failed. Built with commit 1352906 https://app.netlify.com/sites/carpentries-intromri/deploys/60996fb2b845c7000787dc87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.