Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first try #54

Merged
Merged

Conversation

drcandacemakedamoore
Copy link
Contributor

This PR changes the table and adds an html tag so this specific part of the page can be linked

Copy link

github-actions bot commented Dec 17, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/SDC-BIDS-IntroMRI/compare/md-outputs..md-outputs-PR-54

The following changes were observed in the rendered markdown documents:

 md5sum.txt             |  2 +-
 scanner-to-computer.md | 19 ++++++++++++-------
 2 files changed, 13 insertions(+), 8 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-12-17 03:25:22 +0000

github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
Copy link
Contributor

@josephmje josephmje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution Candace.

@josephmje josephmje merged commit 659646a into carpentries-incubator:main Dec 20, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
Auto-generated via `{sandpaper}`
Source  : 659646a
Branch  : main
Author  : Michael Joseph <josephmje.22@gmail.com>
Time    : 2024-12-20 14:06:09 +0000
Message : Merge pull request #54 from drcandacemakedamoore/trytolink

first try
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
Auto-generated via `{sandpaper}`
Source  : 295a462
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-12-20 14:06:52 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 659646a
Branch  : main
Author  : Michael Joseph <josephmje.22@gmail.com>
Time    : 2024-12-20 14:06:09 +0000
Message : Merge pull request #54 from drcandacemakedamoore/trytolink

first try
@jhlegarreta
Copy link
Contributor

Sorry for the late review. A couple of relevant comments:

  • Use a descriptive commit message subject and body, otherwise things get difficult when inspecting changes and the history.
  • Any change to the Markdown files should be accompanied by the corresponding change to the Jupyter notebooks.

PR #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants