Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kapp should double check that k8s api returns labeled resources #160

Closed
cppforlife opened this issue Nov 12, 2020 · 3 comments
Closed

kapp should double check that k8s api returns labeled resources #160

cppforlife opened this issue Nov 12, 2020 · 3 comments
Assignees
@cari-lynn @gcheadle-vmware
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@cppforlife
Copy link
Contributor

currently kapp trusts that k8s api returns resources based on the label query specified. it appears that if aggregated api impl come into play there is no guarantee that they return resources filted by label as requested (antrea for example did not implement label selector).
@cppforlife cppforlife added the enhancement This issue is a feature request label Nov 12, 2020
@danielhelfand
Copy link
Contributor

As a question on this, would the result of this labeled resource check result in an error message to the user? Or is there some other plan for the recovery in this scenario?

@cppforlife
Copy link
Contributor Author

would the result of this labeled resource check result in an error message to the user

if resource is not appropriately labeled, then it would "eliminate" resource from further processing like diffing (== consider that resource as not being there). this would allow kapp to work with aggregated apis that do not behave up to spec.

@paulczar paulczar mentioned this issue Dec 18, 2020
Closed
@cari-lynn cari-lynn linked a pull request Jan 28, 2021 that will close this issue
WIP: dumps resources that do not have labels #176
Closed
@aaronshurley aaronshurley added Epic and removed Epic labels Feb 23, 2021
@gcheadle-vmware gcheadle-vmware self-assigned this Feb 23, 2021
@gcheadle-vmware gcheadle-vmware added the carvel accepted This issue should be considered for future work and that the triage process has been completed label Feb 23, 2021
@seemiller seemiller mentioned this issue Feb 23, 2021
Closed
9 tasks
@cari-lynn cari-lynn self-assigned this Feb 24, 2021
gcheadle-vmware pushed a commit that referenced this issue Mar 4, 2021
@cari-lynn @gcheadle-vmware
Filter resources with label selector to catch mistakes by an aggregat…
b47889d 
…ed api (#160)

Signed-off-by: Garrett Cheadle <gcheadle@vmware.com>
gcheadle-vmware pushed a commit that referenced this issue Mar 4, 2021
@cari-lynn @gcheadle-vmware
Filter resources with label selector to catch mistakes by an aggregat…
82580ed 
…ed api (#160)

Signed-off-by: Garrett Cheadle <gcheadle@vmware.com>
gcheadle-vmware pushed a commit that referenced this issue Mar 4, 2021
@cari-lynn @gcheadle-vmware
Filter resources with label selector to catch mistakes by an aggregat…
e4262f2 
…ed api (#160)

Signed-off-by: Garrett Cheadle <gcheadle@vmware.com>
@aaronshurley aaronshurley added the in progress Work has begun by a community member or a maintainer; this issue may be included in a future release label Mar 9, 2021
@cari-lynn cari-lynn removed the in progress Work has begun by a community member or a maintainer; this issue may be included in a future release label Mar 10, 2021
@cari-lynn
Copy link
Contributor

This is available in release v0.36.0

danielhelfand added a commit to carvel-dev/kapp-controller that referenced this issue Mar 10, 2021
@danielhelfand
bump kapp version to v0.36.0
f264f2f 
Addresses issue carvel-dev/kapp#160
@danielhelfand danielhelfand mentioned this issue Mar 10, 2021
Merged
cppforlife pushed a commit to carvel-dev/kapp-controller that referenced this issue Mar 11, 2021
@danielhelfand
bump kapp version to v0.36.0 (#132)
081ce79 
Addresses issue carvel-dev/kapp#160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cari-lynn cari-lynn

@gcheadle-vmware gcheadle-vmware

Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: dumps resources that do not have labels paulczar/carvel-kapp
5 participants
@cppforlife @aaronshurley @danielhelfand @cari-lynn @gcheadle-vmware