WIP: dumps resources that do not have labels #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
cppforlife
reviewed
Jan 6, 2021
| // as they cannot be kapp resources | ||
| var newResources []Resource | ||
| for _, res := range resources { | ||
| if len(res.Labels()) > 0 { |
There was a problem hiding this comment.
hmm, this would break usage of kapp -a label: or other negative-matching variants.
|
Closing due to fix in #198 |
github-actions
bot
added
the
carvel triage
aaronshurley
removed
the
carvel triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very naive solution to #160 that I'm using in the interim. Probably too naive to be merged in, but could be useful for folks in the meantime.
Signed-off-by: Paul Czarkowski username.taken@gmail.com