Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter resources by label to catch aggregated api mistakes #198

Merged
merged 5 commits into from
Mar 5, 2021
Merged

Filter resources by label to catch aggregated api mistakes #198

merged 5 commits into from
Mar 5, 2021
+22,551 −23

Commits on Mar 4, 2021

  1. Add Resources interface 

    - Change Resources type to Impl
    @gcheadle-vmware
    gcheadle-vmware committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    2ab6fdd View commit details
    Browse the repository at this point in the history

  2. Filter resources with label selector to catch mistakes by an aggregat… 

    …ed api (#160)

Signed-off-by: Garrett Cheadle <gcheadle@vmware.com>
    @cari-lynn @gcheadle-vmware
    cari-lynn authored and gcheadle-vmware committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    e4262f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Remove mocks and update test 

    * renamed Impl -> ResourcesImpl
* update comment about aggregated APIs
    @gcheadle-vmware
    gcheadle-vmware committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    91b61b0 View commit details
    Browse the repository at this point in the history

  2. Add exclude rule to golangci-lint 

    * ignores stuttering linting error
    @gcheadle-vmware
    gcheadle-vmware committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    b1ca53e View commit details
    Browse the repository at this point in the history

  3. Update test package to resources_test

    @gcheadle-vmware
    gcheadle-vmware committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    7168dfc View commit details
    Browse the repository at this point in the history