Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run benchmark tests in CI to avoid error #155

Closed
hsluoyz opened this issue Oct 25, 2021 · 4 comments · Fixed by #162
Closed

Don't run benchmark tests in CI to avoid error #155

hsluoyz opened this issue Oct 25, 2021 · 4 comments · Fixed by #162
Assignees
Labels
bug Something isn't working

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Oct 25, 2021

See: https://github.com/casbin/casbin-cpp/runs/3990335532?check_suite_focus=true

image

We should not run benchmark tests in CI, because it takes too long time and CI will kill the process. People can run them in their local machine by themselves.

Can anyone remove it?

@casbin-bot
Copy link
Member

@casbin-bot casbin-bot added the bug Something isn't working label Oct 25, 2021
@EmperorYP7
Copy link
Member

People can run them in their local machine by themselves.

I think we can use some alternatives for consistent benchmarking. We should also keep track of it whenever new code is pushed or a new PR is made to the project.

Can anyone remove it?

Sure!

@hsluoyz
Copy link
Member Author

hsluoyz commented Oct 28, 2021

@sheny1xuan @noob20000405 can you try the alternative solutions?

@noob20000405
Copy link
Contributor

@sheny1xuan @noob20000405 can you try the alternative solutions?

Sure! I'll do it latter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants