fix: expedite benchmark tests #159
Conversation
|
@EmperorYP7 @divy9881 please review |
Signed-off-by: noob20000405 <vincent4869code@gmail.com>
|
@sheny1xuan plz review |
There was a problem hiding this comment.
@noob20000405 Kindly make sure you checkout to another branch and create a PR from it to casbin:master from now on. You might need to fork this repo several times or make many merge commits on noob20000405:master branch if you don't do this.
Thank you sincerely for your help, so for this time am I supposed to recreate a PR? |
No. This PR will suffice for now. |
| @@ -60,53 +60,7 @@ static void BenchmarkCachedRBACModelSmall(benchmark::State& state) { | |||
| e.Enforce(params); | |||
| } | |||
|
|
|||
| BENCHMARK(BenchmarkCachedRBACModelSmall); | |||
There was a problem hiding this comment.
I think commenting this out is better than deleting it right away. If we comment out only this specific line, the benchmark for BenchmarkCachedRBACModelSmall won't run. However, the user has the option to run it anyway.
There was a problem hiding this comment.
What do you think about this @noob20000405?
There was a problem hiding this comment.
@EmperorYP7 Totally agree with you, I'll change it now.
| e.Enforce(params); | ||
| } | ||
|
|
||
| // BENCHMARK(BenchmarkCachedRBACModelMedium); |
| params = { "user" + std::to_string(GetRandom1000()), "data" + std::to_string(GetRandom1000()/10), "read" }, e.HasPolicy(params); | ||
| } | ||
|
|
||
| BENCHMARK(BenchmarkHasPolicyMedium); |
| } | ||
| } | ||
|
|
||
| BENCHMARK(BenchmarkHasPolicyLarge); |
| @@ -101,38 +73,9 @@ static void BenchmarkAddPolicySmall(benchmark::State& state) { | |||
| params = {"user" + std::to_string(GetRandom100() + 100), "data" + std::to_string((GetRandom100() + 100)/10), "read"}, e.AddPolicy(params); | |||
| } | |||
|
|
|||
| BENCHMARK(BenchmarkAddPolicySmall); | |||
| } | ||
| } | ||
|
|
||
| BENCHMARK(BenchmarkAddPolicyMedium); |
There was a problem hiding this comment.
and so on. Hope you got the pattern
|
Replaced by: #161 |
Fix: #155
Description
There were some loops for benchmark tests used in some functions that could take long time, e.g.,
Except the number of iterations of loop, these functions were almost the same.
I deleted those functions called *Medium() and *Large(), then replaced the name of *Small() by *Loop(), it can save a lot of time.
Screenshots/Testimonials