-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add a benchmark tests option #162
Conversation
Signed-off-by: noob20000405 <vincent4869code@gmail.com>
Signed-off-by: noob20000405 <vincent4869code@gmail.com>
@EmperorYP7 @divy9881 @sheny1xuan please review |
Signed-off-by: noob20000405 <vincent4869code@gmail.com>
@sheny1xuan @EmperorYP7 I didn't use macro but I think it meets your suggestion, if not, please give me some instructions. Thank you in advance ;)) |
tests/benchmarks/CMakeLists.txt
Outdated
@@ -14,6 +14,8 @@ | |||
|
|||
add_definitions(-DCASBIN_PROJECT_DIR=${CMAKE_SOURCE_DIR}) | |||
|
|||
option(INTENSIVE_BENCHMARK OFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed your suggestion, please review again. Thanks.
@noob20000405 please do not raise new PRs for the same issue. You can always re-use the existing PR for doing anything: reworking commits, appending commits, etc. |
@EmperorYP7 plz review |
Signed-off-by: noob20000405 <vincent4869code@gmail.com>
Signed-off-by: noob20000405 <vincent4869code@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎉 This PR is included in version 1.39.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fix: #155
Description
I moved all intensive benchmark tests functions like
*Medium()
and*Large()
to some new files called*_inten.cpp
. And added an option for intensive tests in the CMake file.To do intensive tests, we need to use command
cmake .. -DINTENSIVE_BENCHMARK=ON
to switch on it.