Bump prerelease pointers #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow-on patch will regenerate Make-managed files. References: * ucoProject/UCO#563 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * ucoProject/UCO#563 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
No effects were observed on Make-managed files. References: * ucoProject/UCO#543 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
A follow-on patch will regenerate Make-managed files. References: * ucoProject/UCO#562 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * ucoProject/UCO#562 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
|
I'm fine with this merging once CI passes. |
plbt5
reviewed
Nov 28, 2023
There was a problem hiding this comment.
I'd suggest to improve the documentation and assure that each triple's Subject is provided with one of the textual properties (sh:message, rdfs:comment, rdfs:seeAlso, ...), providing some description of the Subject. For instance, lines 1034-1041 specify the datatype-objects shape, but I need to read the code to understand its working.
There was a problem hiding this comment.
Fair feedback! I'm porting it over to UCO Issue 562.
plbt5
approved these changes
Nov 28, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.