Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prerelease pointers #259

Merged
merged 5 commits into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dependencies/CASE-unstable
2 changes: 1 addition & 1 deletion dependencies/CASE-unstable-2.0.0
25 changes: 15 additions & 10 deletions ontology/CASE-unstable-2.0.0.ttl
Copy link
Contributor

@plbt5 plbt5 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajnelson-nist :

I'd suggest to improve the documentation and assure that each triple's Subject is provided with one of the textual properties (sh:message, rdfs:comment, rdfs:seeAlso, ...), providing some description of the Subject. For instance, lines 1034-1041 specify the datatype-objects shape, but I need to read the code to understand its working.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair feedback! I'm porting it over to UCO Issue 562.

Original file line number Diff line number Diff line change
Expand Up @@ -1031,6 +1031,15 @@ uco-owl:ontologyIRI-versionIRI-prerequisite-shape
sh:targetSubjectsOf owl:versionIRI ;
.

uco-owl:sh-datatype-objects-shape
a sh:NodeShape ;
sh:not [
a sh:NodeShape ;
sh:class owl:Class ;
] ;
sh:targetObjectsOf sh:datatype ;
.

uco-owl:versionIRI-multiversion-shape
a sh:PropertyShape ;
rdfs:seeAlso <https://www.w3.org/TR/owl2-syntax/#Imports> ;
Expand Down Expand Up @@ -1170,14 +1179,10 @@ action:Action

action:Action-disjointWith-Event-shape
a sh:NodeShape ;
sh:message "action:Action and core:event are disjoint classes."@en ;
sh:node [
sh:message "action:Action and core:Event are disjoint classes."@en ;
sh:not [
a sh:NodeShape ;
rdfs:comment "This blank node is provided to avoid a SHACL multiple-inheritance issue."@en ;
sh:not [
a sh:NodeShape ;
sh:class core:Event ;
] ;
sh:class core:Event ;
] ;
sh:targetClass action:Action ;
.
Expand Down Expand Up @@ -17061,9 +17066,9 @@ pattern:LogicalPattern
rdfs:label "LogicalPattern"@en ;
rdfs:comment "A logical pattern is a grouping of characteristics unique to an informational pattern expressed via a structured pattern expression following the rules of logic."@en ;
sh:property [
sh:datatype pattern:PatternExpression ;
sh:class pattern:PatternExpression ;
sh:maxCount "1"^^xsd:integer ;
sh:nodeKind sh:Literal ;
sh:nodeKind sh:IRI ;
sh:path pattern:patternExpression ;
] ;
sh:targetClass pattern:LogicalPattern ;
Expand Down Expand Up @@ -17092,7 +17097,7 @@ pattern:PatternExpression
.

pattern:patternExpression
a owl:DatatypeProperty ;
a owl:ObjectProperty ;
rdfs:label "patternExpression"@en ;
rdfs:comment "An explicit logical pattern expression."@en ;
rdfs:range pattern:PatternExpression ;
Expand Down
10 changes: 3 additions & 7 deletions ontology/CASE-unstable.ttl
Original file line number Diff line number Diff line change
Expand Up @@ -1170,14 +1170,10 @@ action:Action

action:Action-disjointWith-Event-shape
a sh:NodeShape ;
sh:message "action:Action and core:event are disjoint classes."@en ;
sh:node [
sh:message "action:Action and core:Event are disjoint classes."@en ;
sh:not [
a sh:NodeShape ;
rdfs:comment "This blank node is provided to avoid a SHACL multiple-inheritance issue."@en ;
sh:not [
a sh:NodeShape ;
sh:class core:Event ;
] ;
sh:class core:Event ;
] ;
sh:targetClass action:Action ;
.
Expand Down
Loading