-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename add_* tool functions #474
Comments
Making everything both consistent and explicit seems like the way to go to me. My vote is for that. |
@h-mayorquin But what's the boundary on 'explicit'? Should it be the full snake case of the native API object class, e.g., |
to differentiate |
Yeah, that would be fine to me. Most people feel umcomfortable with that much verbosity but I don't. I am more concern with the consistency in the suffix to fully indicate the action that with the part of the name that characterize the object being added. |
Originally posted by @h-mayorquin in #455 (comment)
So to clarify, we want all the helper functions under
tools
to follow the conventionadd_{native API object/class type}_to_nwb
E.g., what is currently
add_sorting
intools.spikeinterface
should becomeadd_sorting_to_nwb
Should this also apply to the
write_*
methods? E.g.,write_sorting
->write_sorting_to_nwb
?The text was updated successfully, but these errors were encountered: