Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_nwbfile to methods in roi extractors #1027

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Should close #474.

@h-mayorquin h-mayorquin self-assigned this Aug 23, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review August 23, 2024 19:02
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) August 25, 2024 20:28
@CodyCBakerPhD CodyCBakerPhD merged commit 727228c into main Aug 25, 2024
35 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the add_to_nwbfile_roi_extractors branch August 25, 2024 21:33
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 52.52525% with 47 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (bd1493c) to head (71cadd1).
Report is 1 commits behind head on main.

Files Patch % Lines
src/neuroconv/tools/roiextractors/roiextractors.py 49.46% 47 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   90.96%   90.67%   -0.30%     
==========================================
  Files         129      129              
  Lines        7847     7879      +32     
==========================================
+ Hits         7138     7144       +6     
- Misses        709      735      +26     
Flag Coverage Δ
unittests 90.67% <52.52%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ainterfaces/ophys/baseimagingextractorinterface.py 95.16% <100.00%> (ø)
...rfaces/ophys/basesegmentationextractorinterface.py 100.00% <100.00%> (ø)
...s/ophys/miniscope/miniscopeimagingdatainterface.py 100.00% <100.00%> (ø)
src/neuroconv/tools/roiextractors/__init__.py 100.00% <ø> (ø)
src/neuroconv/tools/roiextractors/roiextractors.py 82.18% <49.46%> (-4.68%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename add_* tool functions
2 participants