Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spikeinterface api to add_nwb #1015

Merged
merged 7 commits into from
Aug 20, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Making progress in #474

Consistent to the interface `add_to_nwb

@CodyCBakerPhD
Copy link
Member

Consistent to the interface `add_to_nwb

For consistency, the method on interfaces and converters is add_to_nwbfile: https://github.com/catalystneuro/neuroconv/blob/main/src/neuroconv/basedatainterface.py#L107

@h-mayorquin
Copy link
Collaborator Author

Consistent to the interface `add_to_nwb

For consistency, the method on interfaces and converters is add_to_nwbfile: https://github.com/catalystneuro/neuroconv/blob/main/src/neuroconv/basedatainterface.py#L107

Correct. Changing to it.

@h-mayorquin h-mayorquin marked this pull request as ready for review August 16, 2024 20:33
@CodyCBakerPhD CodyCBakerPhD linked an issue Aug 19, 2024 that may be closed by this pull request
@h-mayorquin h-mayorquin merged commit 60ca62f into main Aug 20, 2024
35 checks passed
@h-mayorquin h-mayorquin deleted the rename_spike_interface_functions branch August 20, 2024 19:56
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 20 lines in your changes missing coverage. Please review.

Project coverage is 91.37%. Comparing base (745b90b) to head (cd34e8c).
Report is 2 commits behind head on main.

Files Patch % Lines
...c/neuroconv/tools/spikeinterface/spikeinterface.py 67.21% 20 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   91.53%   91.37%   -0.16%     
==========================================
  Files         129      129              
  Lines        7852     7860       +8     
==========================================
- Hits         7187     7182       -5     
- Misses        665      678      +13     
Flag Coverage Δ
unittests 91.37% <70.58%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...erfaces/ecephys/baserecordingextractorinterface.py 95.87% <100.00%> (ø)
...nterfaces/ecephys/basesortingextractorinterface.py 79.79% <100.00%> (ø)
src/neuroconv/tools/spikeinterface/__init__.py 100.00% <ø> (ø)
...c/neuroconv/tools/spikeinterface/spikeinterface.py 91.68% <67.21%> (-3.43%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename add_* tool functions
2 participants