-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CATCH_CONFIG_DISABLE fails CAPTURE(i,j) #2316
Labels
Comments
laoshaw
changed the title
CATCH_CONFIG_DISABLE failes CAPTURE(i,j)
CATCH_CONFIG_DISABLE fails CAPTURE(i,j)
Oct 30, 2021
horenmar
added
Good First Issue
Issues that can be undertaken by someone new to the project
Bug
labels
Oct 30, 2021
johnbeard
added a commit
to johnbeard/Catch2
that referenced
this issue
Mar 2, 2022
This causes errors on CAPTURE(a,b) when CATCH_CONFIG_DISABLE is set.
johnbeard
added a commit
to johnbeard/Catch2
that referenced
this issue
Mar 2, 2022
This caused errors on CAPTURE(a,b) when CATCH_CONFIG_DISABLE is set. Closes: catchorg#2316
horenmar
pushed a commit
that referenced
this issue
Mar 4, 2022
johnbeard
added a commit
to johnbeard/Catch2
that referenced
this issue
Mar 5, 2022
This makes sure that CAPTURE works when called with variadic arguments, and also works that way when disabled. The underlying fix to catchorg#2316 is not applicable (CAPTURE is already variadic when disabled). This is a port of 5e94498 to the devel branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
when I turn on CATCH_CONFIG_DISABLE, all CAPTURE(i,j) , i.e. more than one arg will err.
Expected behavior
No such error
Reproduction steps
Build below code with -DCATCH_CONFIG_DISABLE
will lead to below errs:
Platform information:
Additional context
My fix is below to get it working:
The text was updated successfully, but these errors were encountered: