CAPTURE not variadic when disabled #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused errors on CAPTURE(a,b) when CATCH_CONFIG_DISABLE is set. Closes: catchorg#2316
Codecov Report
@@ Coverage Diff @@
## v2.x #2378 +/- ##
=======================================
Coverage 90.10% 90.10%
=======================================
Files 113 113
Lines 5038 5038
=======================================
Hits 4539 4539
Misses 499 499 |
|
Thanks, but you should also add a test to |
|
Re the X01 test: Is that right? The test fails due to that |
johnbeard
force-pushed
the
disable_capture
branch
from
58226bb to
ecae3d9
Compare
|
I don't see a failing CI build so I am not sure what I mean, but the changes look correct. If nothing comes up, I'll merge this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused errors on CAPTURE(a,b) when CATCH_CONFIG_DISABLE
is set.
Closes: #2316