chore: Split out actions, use code coverage test #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
suggested changes
Apr 27, 2023
Comment on lines
+40
to
+43
| with: | ||
| profile: minimal | ||
| toolchain: stable | ||
| override: true |
There was a problem hiding this comment.
Want to have the llvm-tools-preview component in there, too (the coverage.sh will auto-install if missing, but it's cleaner to install upfront I think).
| toolchain: stable | ||
| override: true | ||
| - name: Tests with Coverage | ||
| run: bash tasks/coverage.sh |
There was a problem hiding this comment.
You'd want to still upload the coverage to codecov...
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 42.40% 42.40%
=======================================
Files 20 20
Lines 2641 2641
=======================================
Hits 1120 1120
Misses 1521 1521 ☔ View full report in Codecov by Sentry. |
# Conflicts: # .github/workflows/correctness.yml # .github/workflows/fmt-actions.yml # .github/workflows/pr-actions.yml
RomainMuller
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out running tests and lint/format checks for cleaner understanding just looking at the review. Also update tests to run code coverage task.